commit dfef6a9196a126b1db22e0f19c8cd0a2a31b6e77
author Lei Zhang <thestig@chromium.org> Tue Oct 24 17:01:26 2023 +0000
committer Pdfium LUCI CQ <pdfium-scoped@luci-project-accounts.iam.gserviceaccount.com> Tue Oct 24 17:01:26 2023 +0000
tree f266ba8beb8c7c38e22a6c7b84d560178898728b
parent b9e0f72fd5aba9d4f5a3889de0c3a286a34635f2

Use aggregate initialization in EmbedderTestEnvironment::SetUp()

Since aggregate initialization requires the members are initialized in
order, this naturally reveals some redundant assignments that can be
removed.

Change-Id: Ib77238a901b4b0d4461544c77bf861d945d1fb85
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/113052
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>

testing/embedder_test_environment.cpp

diff --git a/testing/embedder_test_environment.cpp b/testing/embedder_test_environment.cpp
index 07e459a..da54048 100644
--- a/testing/embedder_test_environment.cpp
+++ b/testing/embedder_test_environment.cpp
@@ -38,22 +38,22 @@
 }
 
 void EmbedderTestEnvironment::SetUp() {
-  FPDF_LIBRARY_CONFIG config;
-  config.version = 4;
-  config.m_pUserFontPaths = nullptr;
-  config.m_v8EmbedderSlot = 0;
-  config.m_pPlatform = nullptr;
-
-  config.m_pUserFontPaths = test_fonts_.font_paths();
+  FPDF_LIBRARY_CONFIG config = {
+      .version = 4,
+      .m_pUserFontPaths = test_fonts_.font_paths(),
 
 #ifdef PDF_ENABLE_V8
-  config.m_pIsolate = V8TestEnvironment::GetInstance()->isolate();
-  config.m_pPlatform = V8TestEnvironment::GetInstance()->platform();
+      .m_pIsolate = V8TestEnvironment::GetInstance()->isolate(),
+      .m_v8EmbedderSlot = 0,
+      .m_pPlatform = V8TestEnvironment::GetInstance()->platform(),
 #else   // PDF_ENABLE_V8
-  config.m_pIsolate = nullptr;
-  config.m_pPlatform = nullptr;
+      .m_pIsolate = nullptr,
+      .m_v8EmbedderSlot = 0,
+      .m_pPlatform = nullptr,
 #endif  // PDF_ENABLE_V8
-  config.m_RendererType = renderer_type_;
+
+      .m_RendererType = renderer_type_,
+  };
 
   FPDF_InitLibraryWithConfig(&config);