commit e23f31b6d8ff6ac2a4b94ee1567b9454e07855cb
author Tom Sepez <tsepez@chromium.org> Fri Jun 07 19:54:48 2024 +0000
committer Pdfium LUCI CQ <pdfium-scoped@luci-project-accounts.iam.gserviceaccount.com> Fri Jun 07 19:54:48 2024 +0000
tree 38190762fc15bbce2f86616325cf3bf0b5bb851a
parent 5d2f722f40a4110e80f2d4df2042ddfacfaf46c9

Add tests for pdfium::span<> interoperability with gmock macros.

PDFium's span is still divergent from base's span, so repeat the
test here from, i.e. https://crrev.com/c/5607486

Change-Id: I4dbaee3f945311a580c2a7ad611195f6dcf3fde3
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/120230
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Thomas Sepez <tsepez@google.com>
Commit-Queue: Tom Sepez <tsepez@chromium.org>

core/fxcrt/pdfium_span_unittest.cpp

diff --git a/core/fxcrt/pdfium_span_unittest.cpp b/core/fxcrt/pdfium_span_unittest.cpp
index 7626eea..dcd319d 100644
--- a/core/fxcrt/pdfium_span_unittest.cpp
+++ b/core/fxcrt/pdfium_span_unittest.cpp
@@ -7,8 +7,12 @@
 #include "core/fxcrt/raw_span.h"
 #include "core/fxcrt/span.h"
 #include "core/fxcrt/unowned_ptr.h"
+#include "testing/gmock/include/gmock/gmock.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
+using ::testing::ElementsAre;
+using ::testing::ElementsAreArray;
+
 // Tests PDFium-modifications to base::span. The name of this file is
 // chosen to avoid collisions with base's span_unittest.cc
 
@@ -39,6 +43,35 @@
   EXPECT_EQ(stuff_span.back(), 3);
 }
 
+TEST(PdfiumSpan, GMockMacroCompatibility) {
+  int arr1[] = {1, 3, 5};
+  int arr2[] = {1, 3, 5};
+  std::vector vec1(std::begin(arr1), std::end(arr1));
+  std::vector vec2(std::begin(arr2), std::end(arr2));
+  pdfium::span<int, 3> static_span1(arr1);
+  pdfium::span<int, 3> static_span2(arr2);
+  pdfium::span<int> dynamic_span1(vec1);
+  pdfium::span<int> dynamic_span2(vec2);
+
+  EXPECT_THAT(arr1, ElementsAreArray(static_span2));
+  EXPECT_THAT(arr1, ElementsAreArray(dynamic_span2));
+
+  EXPECT_THAT(vec1, ElementsAreArray(static_span2));
+  EXPECT_THAT(vec1, ElementsAreArray(dynamic_span2));
+
+  EXPECT_THAT(static_span1, ElementsAre(1, 3, 5));
+  EXPECT_THAT(static_span1, ElementsAreArray(arr2));
+  EXPECT_THAT(static_span1, ElementsAreArray(static_span2));
+  EXPECT_THAT(static_span1, ElementsAreArray(dynamic_span2));
+  EXPECT_THAT(static_span1, ElementsAreArray(vec2));
+
+  EXPECT_THAT(dynamic_span1, ElementsAre(1, 3, 5));
+  EXPECT_THAT(dynamic_span1, ElementsAreArray(arr2));
+  EXPECT_THAT(dynamic_span1, ElementsAreArray(static_span2));
+  EXPECT_THAT(dynamic_span1, ElementsAreArray(dynamic_span2));
+  EXPECT_THAT(dynamic_span1, ElementsAreArray(vec2));
+}
+
 TEST(PdfiumSpanDeathTest, EmptySpanIndex) {
   pdfium::span<int> empty_span;
   EXPECT_DEATH(empty_span[0] += 1, "");