commit e3e37bac7c2b12317f62517b4b5f7623ca5cb786
author Tom Sepez <tsepez@chromium.org> Fri Sep 06 00:35:25 2024 +0000
committer Pdfium LUCI CQ <pdfium-scoped@luci-project-accounts.iam.gserviceaccount.com> Fri Sep 06 00:35:25 2024 +0000
tree da75901cc4b583e210b5fc0c60b07260d6dda64c
parent 85c7c38c1c6811cb08e214cd95e4e15b1490cf65

Remove stray const qualifier from CPDF_Parser.

This prevents a subsequent std::move() at line 762 from actually doing
a move, since it can't update the const local.

Bug: 364788123
Change-Id: Ie3671a9ba9c566d57071b7065b286b5b2ec517b1
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/124070
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Tom Sepez <tsepez@google.com>
Commit-Queue: Tom Sepez <tsepez@chromium.org>

core/fpdfapi/parser/cpdf_parser.cpp

diff --git a/core/fpdfapi/parser/cpdf_parser.cpp b/core/fpdfapi/parser/cpdf_parser.cpp
index c7f0044..a2e2213 100644
--- a/core/fpdfapi/parser/cpdf_parser.cpp
+++ b/core/fpdfapi/parser/cpdf_parser.cpp
@@ -744,9 +744,8 @@
       const uint32_t gen_num = numbers[1].first;
 
       m_pSyntax->SetPos(obj_pos);
-      const RetainPtr<CPDF_Stream> pStream =
-          ToStream(m_pSyntax->GetIndirectObject(
-              nullptr, CPDF_SyntaxParser::ParseType::kStrict));
+      RetainPtr<CPDF_Stream> pStream = ToStream(m_pSyntax->GetIndirectObject(
+          nullptr, CPDF_SyntaxParser::ParseType::kStrict));
 
       if (pStream && pStream->GetDict()->GetNameFor("Type") == "XRef") {
         cross_ref_table = CPDF_CrossRefTable::MergeUp(