commit ea8d8d856bb644bd9348d2424d284e76da0f487b
author Tom Sepez <tsepez@chromium.org> Fri Nov 08 20:31:35 2019 +0000
committer Chromium commit bot <commit-bot@chromium.org> Fri Nov 08 20:31:35 2019 +0000
tree b0160eee41fc18ea591572c11af11f7697fe4da8
parent e6ea9aebf3c361ee10e4cd550f54a9f263d9a446

Remove CBC_Writer::Set{Background,Barcode}Color().

These are only called from the same-named methods in CBC_CodeBase,
which are themselves not called. Replace the members formerly set
with static constants.

Change-Id: Ic75409924d9502bfedf8018b757d824b09a2bcf1
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/62030
Commit-Queue: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>

fxbarcode/BC_Writer.h

diff --git a/fxbarcode/BC_Writer.h b/fxbarcode/BC_Writer.h
index c358599..cf7f43b 100644
--- a/fxbarcode/BC_Writer.h
+++ b/fxbarcode/BC_Writer.h
@@ -10,8 +10,6 @@
 #include "core/fxge/fx_dib.h"
 #include "fxbarcode/BC_Library.h"
 
-class CFX_DIBitmap;
-
 class CBC_Writer {
  public:
   CBC_Writer();
@@ -21,8 +19,6 @@
   virtual bool SetModuleWidth(int32_t moduleWidth);
   virtual bool SetHeight(int32_t height);
   virtual bool SetWidth(int32_t width);
-  virtual void SetBackgroundColor(FX_ARGB backgroundColor);
-  virtual void SetBarcodeColor(FX_ARGB foregroundColor);
   virtual bool SetTextLocation(BC_TEXT_LOC location);
   virtual bool SetWideNarrowRatio(int8_t ratio);
   virtual bool SetStartChar(char start);
@@ -30,14 +26,15 @@
   virtual bool SetErrorCorrectionLevel(int32_t level);
 
  protected:
+  static const FX_ARGB kBarColor = 0xff000000;
+  static const FX_ARGB kBackgroundColor = 0xffffffff;
+
   int32_t m_CharEncoding = 0;
   int32_t m_ModuleHeight = 1;
   int32_t m_ModuleWidth = 1;
   int32_t m_Height = 320;
   int32_t m_Width = 640;
   FXDIB_Format m_colorSpace = FXDIB_Argb;
-  FX_ARGB m_barColor = 0xff000000;
-  FX_ARGB m_backgroundColor = 0xffffffff;
 };
 
 #endif  // FXBARCODE_BC_WRITER_H_