Fix an old TODO() in CPDF_InteractiveForm Change-Id: I4edddd211af21f52d289c63867f5c45358952d64 Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/86857 Reviewed-by: Lei Zhang <thestig@chromium.org> Commit-Queue: Tom Sepez <tsepez@chromium.org>
diff --git a/core/fpdfdoc/cpdf_interactiveform.cpp b/core/fpdfdoc/cpdf_interactiveform.cpp index d9a791b..14c2fea 100644 --- a/core/fpdfdoc/cpdf_interactiveform.cpp +++ b/core/fpdfdoc/cpdf_interactiveform.cpp
@@ -744,7 +744,7 @@ return m_pFormDict ? m_pFormDict->GetIntegerFor("Q", 0) : 0; } -void CPDF_InteractiveForm::ResetForm(const std::vector<CPDF_FormField*>& fields, +void CPDF_InteractiveForm::ResetForm(pdfium::span<CPDF_FormField*> fields, bool bIncludeOrExclude) { CFieldTree::Node* pRoot = m_pFieldTree->GetRoot(); const size_t nCount = pRoot->CountFields();
diff --git a/core/fpdfdoc/cpdf_interactiveform.h b/core/fpdfdoc/cpdf_interactiveform.h index 2c0e1e2..d70da7c 100644 --- a/core/fpdfdoc/cpdf_interactiveform.h +++ b/core/fpdfdoc/cpdf_interactiveform.h
@@ -21,6 +21,7 @@ #include "core/fxcrt/fx_string.h" #include "core/fxcrt/retain_ptr.h" #include "core/fxcrt/unowned_ptr.h" +#include "third_party/base/span.h" class CFieldTree; class CFDF_Document; @@ -84,10 +85,7 @@ bool bIncludeOrExclude) const; void ResetForm(); - - // TODO(tsepez): Use a span. - void ResetForm(const std::vector<CPDF_FormField*>& fields, - bool bIncludeOrExclude); + void ResetForm(pdfium::span<CPDF_FormField*> fields, bool bIncludeOrExclude); void SetNotifierIface(NotifierIface* pNotify); void FixPageFields(CPDF_Page* pPage);