commit ec4ba9c02d0b0d66c3a4f005acf480e6d593b97c
author Lei Zhang <thestig@chromium.org> Wed Aug 07 19:22:22 2024 +0000
committer Pdfium LUCI CQ <pdfium-scoped@luci-project-accounts.iam.gserviceaccount.com> Wed Aug 07 19:22:22 2024 +0000
tree 5f91b4a12ac628ad504bfca71505a4a9d24b97b1
parent e8ef2510e3c0c8c23d0728706a4b367e80cee21b

Reduce float usage inside cpdf_generateap.cpp

Change some float constants, whose value is an integer, to be integers
instead. This avoids some ostringstream::operator<<(float) usage.

Change-Id: I04fd99935a3fc68d51fc656e7fa1c4f437c9de1c
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/122931
Reviewed-by: Tom Sepez <tsepez@google.com>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>

core/fpdfdoc/cpdf_generateap.cpp

diff --git a/core/fpdfdoc/cpdf_generateap.cpp b/core/fpdfdoc/cpdf_generateap.cpp
index 49e90da..d2c50a2 100644
--- a/core/fpdfdoc/cpdf_generateap.cpp
+++ b/core/fpdfdoc/cpdf_generateap.cpp
@@ -433,11 +433,11 @@
   sAppStream << GenerateColorAP(CFX_Color(CFX_Color::Type::kRGB, 0, 0, 0),
                                 PaintOperation::kStroke);
 
-  constexpr float kBorderWidth = 1;
-  WriteFloat(sAppStream, kBorderWidth) << " w\n";
+  constexpr int kBorderWidth = 1;
+  sAppStream << kBorderWidth << " w\n";
 
-  constexpr float kHalfWidth = kBorderWidth / 2;
-  constexpr float kTipDelta = 4;
+  constexpr float kHalfWidth = kBorderWidth / 2.0f;
+  constexpr int kTipDelta = 4;
 
   CFX_FloatRect outerRect1 = rect;
   outerRect1.Deflate(kHalfWidth, kHalfWidth);
@@ -722,7 +722,7 @@
 
   RetainPtr<const CPDF_Array> pArray = pAnnotDict->GetArrayFor("QuadPoints");
   if (pArray) {
-    static constexpr float kLineWidth = 1.0f;
+    static constexpr int kLineWidth = 1;
     sAppStream << kLineWidth << " w ";
     size_t nQuadPointCount = CPDF_Annot::QuadPointCount(pArray.Get());
     for (size_t i = 0; i < nQuadPointCount; ++i) {
@@ -839,8 +839,8 @@
 
   RetainPtr<const CPDF_Array> pArray = pAnnotDict->GetArrayFor("QuadPoints");
   if (pArray) {
-    static constexpr float kLineWidth = 1.0f;
-    static constexpr float kDelta = 2.0f;
+    static constexpr int kLineWidth = 1;
+    static constexpr int kDelta = 2;
     sAppStream << kLineWidth << " w ";
     size_t nQuadPointCount = CPDF_Annot::QuadPointCount(pArray.Get());
     for (size_t i = 0; i < nQuadPointCount; ++i) {
@@ -889,13 +889,13 @@
 
   RetainPtr<const CPDF_Array> pArray = pAnnotDict->GetArrayFor("QuadPoints");
   if (pArray) {
-    static constexpr float kLineWidth = 1.0f;
     size_t nQuadPointCount = CPDF_Annot::QuadPointCount(pArray.Get());
     for (size_t i = 0; i < nQuadPointCount; ++i) {
       CFX_FloatRect rect = CPDF_Annot::RectFromQuadPoints(pAnnotDict, i);
       rect.Normalize();
 
       float fY = (rect.top + rect.bottom) / 2;
+      constexpr int kLineWidth = 1;
       sAppStream << kLineWidth << " w " << rect.left << " " << fY << " m "
                  << rect.right << " " << fY << " l S\n";
     }