commit f22325c95a3f76c27b198e5e2a49ab1684160e0d
author Alan Screen <awscreen@google.com> Wed Jan 31 23:51:20 2024 +0000
committer Pdfium LUCI CQ <pdfium-scoped@luci-project-accounts.iam.gserviceaccount.com> Wed Jan 31 23:51:20 2024 +0000
tree 027f6963e3a6f32d99cf348f3c94d3400d1242fc
parent ccc38c258c8b58ba6646a204bc957caba63bb35a

Make PDF_USE_SKIA a public build definition

Move the build definition for PDF_USE_SKIA into the public
configuration. This is necessary to enable embedders to use the
public APIs which are controlled by it, such as FPDF_FFLDrawSkia()
and FPDF_RenderPageSkia().

Bug: pdfium:11
Change-Id: Ibf35432691fccecd8b4737e1a4737dd0fa9ae4ad
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/115870
Commit-Queue: Alan Screen <awscreen@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>

BUILD.gn

diff --git a/BUILD.gn b/BUILD.gn
index 2b1f97f..b4815b7 100644
--- a/BUILD.gn
+++ b/BUILD.gn
@@ -40,12 +40,8 @@
     defines += [ "PDF_ENABLE_CLICK_LOGGING" ]
   }
 
-  if (pdf_use_skia) {
-    defines += [ "PDF_USE_SKIA" ]
-
-    if (pdf_enable_fontations) {
-      defines += [ "PDF_ENABLE_FONTATIONS" ]
-    }
+  if (pdf_use_skia && pdf_enable_fontations) {
+    defines += [ "PDF_ENABLE_FONTATIONS" ]
   }
 
   if (pdf_use_partition_alloc) {
@@ -261,6 +257,10 @@
       }
     }
   }
+
+  if (pdf_use_skia) {
+    defines += [ "PDF_USE_SKIA" ]
+  }
 }
 
 config("pdfium_core_config") {