commit f267f5acee65b3c7aa00e3b6a474729da1d75b60
author Lei Zhang <thestig@chromium.org> Mon Jun 07 19:35:55 2021 +0000
committer Pdfium LUCI CQ <pdfium-scoped@luci-project-accounts.iam.gserviceaccount.com> Mon Jun 07 19:35:55 2021 +0000
tree bf1281fda3b3c805ade6f08f085c24ff2adf0e2f
parent be79d1b2aaa0a62f641a6602253477d78d819422

Deal with false positive build/include_what_you_use cpplint errors.

Change-Id: Icb7bd3bb5894e55a16647397eb6e6ebe91bf02d1
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/81491
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>

fxjs/xfa/cfxjse_mapmodule_unittest.cpp

diff --git a/fxjs/xfa/cfxjse_mapmodule_unittest.cpp b/fxjs/xfa/cfxjse_mapmodule_unittest.cpp
index 894b209..7a51aab 100644
--- a/fxjs/xfa/cfxjse_mapmodule_unittest.cpp
+++ b/fxjs/xfa/cfxjse_mapmodule_unittest.cpp
@@ -23,12 +23,12 @@
 
 TEST(CFXJSEMapModule, InsertDelete) {
   const int value = 101;
-  WideString string(L"foo");
+  WideString str(L"foo");
   CXFA_Measurement measure(L"1 pt");
   CFXJSE_MapModule module;
 
   module.SetValue(100, value);
-  module.SetString(200, string);
+  module.SetString(200, str);
   module.SetMeasurement(300, measure);
   EXPECT_TRUE(module.HasKey(100));
   EXPECT_TRUE(module.HasKey(200));
@@ -39,7 +39,7 @@
   EXPECT_FALSE(module.GetMeasurement(100).has_value());
 
   EXPECT_FALSE(module.GetValue(200).has_value());
-  EXPECT_EQ(module.GetString(200).value(), string);
+  EXPECT_EQ(module.GetString(200).value(), str);
   EXPECT_FALSE(module.GetMeasurement(200).has_value());
 
   EXPECT_FALSE(module.GetValue(300).has_value());
@@ -60,7 +60,7 @@
 
 TEST(CFXJSEMapModule, KeyCollision) {
   const int value = 37;
-  WideString string(L"foo");
+  WideString str(L"foo");
   CXFA_Measurement measure(L"1 pt");
   CFXJSE_MapModule module;
 
@@ -70,10 +70,10 @@
   EXPECT_FALSE(module.GetString(100).has_value());
   EXPECT_FALSE(module.GetMeasurement(100).has_value());
 
-  module.SetString(100, string);
+  module.SetString(100, str);
   EXPECT_TRUE(module.HasKey(100));
   EXPECT_FALSE(module.GetValue(100).has_value());
-  EXPECT_EQ(module.GetString(100).value(), string);
+  EXPECT_EQ(module.GetString(100).value(), str);
   EXPECT_FALSE(module.GetMeasurement(100).has_value());
 
   module.SetMeasurement(100, measure);

fxjs/xfa/cjx_occur.cpp

diff --git a/fxjs/xfa/cjx_occur.cpp b/fxjs/xfa/cjx_occur.cpp
index 701e947..15f428f 100644
--- a/fxjs/xfa/cjx_occur.cpp
+++ b/fxjs/xfa/cjx_occur.cpp
@@ -30,6 +30,7 @@
   occur->SetMax(fxv8::ReentrantToInt32Helper(pIsolate, *pValue));
 }
 
+// NOLINTNEXTLINE(build/include_what_you_use)
 void CJX_Occur::min(v8::Isolate* pIsolate,
                     v8::Local<v8::Value>* pValue,
                     bool bSetting,