commit f605937189e44976cee54833e092d79d6d45b828
author Tom Sepez <tsepez@chromium.org> Fri Nov 16 19:31:40 2018 +0000
committer Chromium commit bot <commit-bot@chromium.org> Fri Nov 16 19:31:40 2018 +0000
tree 1e5dd84177c19db002fad19cae6b4c0d87c8f288
parent 3c5f01a03b96d1c1ffe9b16f4acf44e69b7bba8c

Add tests for radiobutton/checkbox JS properties.

Fix bad indexing discovered as a result.

Change-Id: I6241ee32d11948ed242cf8a0b9f8898e8769a869
Reviewed-on: https://pdfium-review.googlesource.com/c/45470
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Tom Sepez <tsepez@chromium.org>

fxjs/cjs_field.cpp

diff --git a/fxjs/cjs_field.cpp b/fxjs/cjs_field.cpp
index eb594cf..2b68f47 100644
--- a/fxjs/cjs_field.cpp
+++ b/fxjs/cjs_field.cpp
@@ -1868,9 +1868,10 @@
     return CJS_Result::Failure(JSMessage::kBadObjectError);
 
   WideString csWCaption = pFormControl->GetNormalCaption();
-  ByteString csBCaption;
+  wchar_t selector = !csWCaption.IsEmpty() ? csWCaption[0] : L'4';
 
-  switch (csWCaption[0]) {
+  ByteString csBCaption;
+  switch (selector) {
     case L'l':
       csBCaption = "circle";
       break;