commit f888579f7fa390bc52ad3d124e3ecec6eb7be1db
author Tom Sepez <tsepez@chromium.org> Tue Oct 30 19:02:50 2018 +0000
committer Chromium commit bot <commit-bot@chromium.org> Tue Oct 30 19:02:50 2018 +0000
tree b5dfe5a5e6f8725896b503de12763f59d657240b
parent d6e911f5b55735f879a363124becba626dacacbf

JSMessage::kUnknownMethod and kTooManyOccurances are XFA-Only.

Save a few bytes in non-xfa case by excluding string equivalents.

Change-Id: I2ff57388b491ae7342ee39a9a626420371b55dad
Reviewed-on: https://pdfium-review.googlesource.com/c/44892
Commit-Queue: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>

fxjs/js_resources.cpp

diff --git a/fxjs/js_resources.cpp b/fxjs/js_resources.cpp
index 29edf89..6edb768 100644
--- a/fxjs/js_resources.cpp
+++ b/fxjs/js_resources.cpp
@@ -49,12 +49,14 @@
       return L"Object no longer exists.";
     case JSMessage::kObjectTypeError:
       return L"Object is of the wrong type.";
-    case JSMessage::kTooManyOccurances:
-      return L"Too many occurances.";
     case JSMessage::kUnknownProperty:
       return L"Unknown property.";
+#ifdef PDF_ENABLE_XFA
+    case JSMessage::kTooManyOccurances:
+      return L"Too many occurances.";
     case JSMessage::kUnknownMethod:
       return L"Unknown method.";
+#endif
   }
   NOTREACHED();
   return L"";

fxjs/js_resources.h

diff --git a/fxjs/js_resources.h b/fxjs/js_resources.h
index 064fd16..576fba5 100644
--- a/fxjs/js_resources.h
+++ b/fxjs/js_resources.h
@@ -30,9 +30,11 @@
   kPermissionError,
   kBadObjectError,
   kObjectTypeError,
-  kTooManyOccurances,
   kUnknownProperty,
+#ifdef PDF_ENABLE_XFA
+  kTooManyOccurances,
   kUnknownMethod,
+#endif
 };
 
 WideString JSGetStringFromID(JSMessage msg);