commit fb159d6100af808a7de556f79f58c4234427cf75
author Lei Zhang <thestig@chromium.org> Mon Jul 31 23:51:23 2023 +0000
committer Pdfium LUCI CQ <pdfium-scoped@luci-project-accounts.iam.gserviceaccount.com> Mon Jul 31 23:51:23 2023 +0000
tree 542bf9e06288eaed97bd1b92d20b77e00eb8f5d8
parent a1c125c988ad7fa2ee8cdcbe204b846f73226360

Remove break statements after NOTREACHED_NORETURN()

They are not reachable. With a sufficiently good NOTREACHED_NORETURN()
implementation, the compiler will generate a Wunreachable-code-break
warning.

Change-Id: I4d86981c77b032dbaf4637a272c9ad406d05f726
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/110510
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>

fpdfsdk/cpdfsdk_formfillenvironment.cpp

diff --git a/fpdfsdk/cpdfsdk_formfillenvironment.cpp b/fpdfsdk/cpdfsdk_formfillenvironment.cpp
index 84df6e1..9aade3a 100644
--- a/fpdfsdk/cpdfsdk_formfillenvironment.cpp
+++ b/fpdfsdk/cpdfsdk_formfillenvironment.cpp
@@ -1040,7 +1040,6 @@
       break;
     case CPDF_Action::Type::kJavaScript:
       NOTREACHED_NORETURN();
-      break;
     case CPDF_Action::Type::kSetOCGState:
     case CPDF_Action::Type::kThread:
     case CPDF_Action::Type::kSound:
@@ -1123,7 +1122,6 @@
         break;
       default:
         NOTREACHED_NORETURN();
-        break;
     }
   });
 }
@@ -1170,7 +1168,6 @@
         break;
       default:
         NOTREACHED_NORETURN();
-        break;
     }
   });
 }

fpdfsdk/cpdfsdk_widget.cpp

diff --git a/fpdfsdk/cpdfsdk_widget.cpp b/fpdfsdk/cpdfsdk_widget.cpp
index c336f5e..0b8083e 100644
--- a/fpdfsdk/cpdfsdk_widget.cpp
+++ b/fpdfsdk/cpdfsdk_widget.cpp
@@ -177,7 +177,6 @@
     case CPDF_AAction::kDocumentOpen:
     case CPDF_AAction::kNumberOfActions:
       NOTREACHED_NORETURN();
-      break;
   }
 
   return eEventType;

fpdfsdk/pwl/cpwl_cblistbox.cpp

diff --git a/fpdfsdk/pwl/cpwl_cblistbox.cpp b/fpdfsdk/pwl/cpwl_cblistbox.cpp
index 492b6ae..0771b26 100644
--- a/fpdfsdk/pwl/cpwl_cblistbox.cpp
+++ b/fpdfsdk/pwl/cpwl_cblistbox.cpp
@@ -75,7 +75,6 @@
       break;
     default:
       NOTREACHED_NORETURN();
-      break;
   }
   return OnNotifySelectionChanged(true, nFlag);
 }

testing/embedder_test.cpp

diff --git a/testing/embedder_test.cpp b/testing/embedder_test.cpp
index 04b805d..4d31c91 100644
--- a/testing/embedder_test.cpp
+++ b/testing/embedder_test.cpp
@@ -678,7 +678,6 @@
       return 4;
     default:
       NOTREACHED_NORETURN();
-      return 0;
   }
 }
 

testing/image_diff/image_diff_png.cpp

diff --git a/testing/image_diff/image_diff_png.cpp b/testing/image_diff/image_diff_png.cpp
index e3ceb91..5a89e35 100644
--- a/testing/image_diff/image_diff_png.cpp
+++ b/testing/image_diff/image_diff_png.cpp
@@ -255,7 +255,6 @@
         break;
       default:
         NOTREACHED_NORETURN();
-        break;
     }
   } else if (channels == 4) {
     switch (state->output_format) {
@@ -273,7 +272,6 @@
         break;
       default:
         NOTREACHED_NORETURN();
-        break;
     }
   } else {
     NOTREACHED_NORETURN();