commit fb252723b0896d79a4b637c11b389aa980f0408a
author Victor Hugo Vianna Silva <victorvianna@google.com> Thu Mar 20 12:34:58 2025 -0700
committer Pdfium LUCI CQ <pdfium-scoped@luci-project-accounts.iam.gserviceaccount.com> Thu Mar 20 12:34:58 2025 -0700
tree 020b548c215ffc4099518b8a86250cc3f0179337
parent 054a44d241879e296193e71d4fbe8552f50773f3

Ban abseil variant.h and utility.h libraries in pdfium

These are just delegating to std now. All usages outside of
third_party were migrated to use std directly.

https://chromium.googlesource.com/chromium/src/+/b3defd119a78557e3d5d10f0683c2380b635c67e/third_party/abseil-cpp/absl/types/variant.h#33

https://chromium.googlesource.com/chromium/src/+/b3defd119a78557e3d5d10f0683c2380b635c67e/third_party/abseil-cpp/absl/utility/utility.h#35

Bug: 40242126
Change-Id: I725308423b3f5872b39021c641ad930739b3baa1
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/129750
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Victor Vianna <victorvianna@google.com>

DEPS

diff --git a/DEPS b/DEPS
index 3b8d194..72acb3a 100644
--- a/DEPS
+++ b/DEPS
@@ -656,6 +656,8 @@
   '-third_party/abseil-cpp/absl/types/any.h',
   '-third_party/abseil-cpp/absl/types/optional.h',
   '-third_party/abseil-cpp/absl/types/span.h',
+  '-third_party/abseil-cpp/absl/types/variant.h',
+  '-third_party/abseil-cpp/absl/utility/utility.h',
 ]
 
 specific_include_rules = {

PRESUBMIT.py

diff --git a/PRESUBMIT.py b/PRESUBMIT.py
index ed1e99f..2024e79 100644
--- a/PRESUBMIT.py
+++ b/PRESUBMIT.py
@@ -97,6 +97,21 @@
         True,
         [_THIRD_PARTY],
     ),
+    (
+        r'/absl::(bad_variant_access|get|holds_alternative|monostate|variant|'
+        r'visit)',
+        ('Abseil\'s variant library is banned, use std.',),
+        True,
+        [_THIRD_PARTY],
+    ),
+    (
+        r'/absl::(apply|exchange|forward|in_place|index_sequence|'
+        r'integer_sequence|make_from_tuple|make_index_sequence|'
+        r'make_integer_sequence|move)',
+        ('Abseil\'s util library is banned, use std.',),
+        True,
+        [_THIRD_PARTY],
+    ),
 )