commit fc26d9386ee779aeace1ff9dc5f2494297e77662
author Lei Zhang <thestig@chromium.org> Mon Jul 01 18:52:45 2024 +0000
committer Pdfium LUCI CQ <pdfium-scoped@luci-project-accounts.iam.gserviceaccount.com> Mon Jul 01 18:52:45 2024 +0000
tree 2545ea4545b43708fefa034c1d87dadeb15b9ce2
parent 264a4a75bd5e4c109a17642018715fdf9d0e0fc0

Remove underscores from CFX_DIBitmap tests

Rename the test names to CFXDIBitmapTest, so there is no confusion with
CFX_DIBitmap itself.

Bug: 42270790
Change-Id: Idfc0995ec61dc26e3e1375df6049cafa38184787
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/121223
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Tom Sepez <tsepez@google.com>

core/fxge/dib/cfx_dibitmap_unittest.cpp

diff --git a/core/fxge/dib/cfx_dibitmap_unittest.cpp b/core/fxge/dib/cfx_dibitmap_unittest.cpp
index c859324..56edd48 100644
--- a/core/fxge/dib/cfx_dibitmap_unittest.cpp
+++ b/core/fxge/dib/cfx_dibitmap_unittest.cpp
@@ -19,7 +19,7 @@
 
 }  // namespace
 
-TEST(CFX_DIBitmap, Create) {
+TEST(CFXDIBitmapTest, Create) {
   auto pBitmap = pdfium::MakeRetain<CFX_DIBitmap>();
   EXPECT_FALSE(pBitmap->Create(400, 300, FXDIB_Format::kInvalid));
 
@@ -27,7 +27,7 @@
   EXPECT_TRUE(pBitmap->Create(400, 300, FXDIB_Format::k1bppRgb));
 }
 
-TEST(CFX_DIBitmap, CalculatePitchAndSizeGood) {
+TEST(CFXDIBitmapTest, CalculatePitchAndSizeGood) {
   // Simple case with no provided pitch.
   std::optional<CFX_DIBitmap::PitchAndSize> result =
       CFX_DIBitmap::CalculatePitchAndSize(100, 200, FXDIB_Format::kArgb, 0);
@@ -57,7 +57,7 @@
   EXPECT_EQ(91000u, result.value().size);
 }
 
-TEST(CFX_DIBitmap, CalculatePitchAndSizeBad) {
+TEST(CFXDIBitmapTest, CalculatePitchAndSizeBad) {
   // Bad width / height.
   static const CFX_Size kBadDimensions[] = {
       {0, 0},   {-1, -1}, {-1, 0},   {0, -1},
@@ -97,7 +97,7 @@
       4194304, 1024, FXDIB_Format::k8bppRgb, 4194304));
 }
 
-TEST(CFX_DIBitmap, CalculatePitchAndSizeBoundary) {
+TEST(CFXDIBitmapTest, CalculatePitchAndSizeBoundary) {
   // Test boundary condition for pitch overflow.
   std::optional<CFX_DIBitmap::PitchAndSize> result =
       CFX_DIBitmap::CalculatePitchAndSize(536870908, 4, FXDIB_Format::k8bppRgb,
@@ -119,7 +119,7 @@
 }
 
 #if defined(PDF_USE_SKIA)
-TEST(CFX_DIBitmap, UnPreMultiply_FromCleared) {
+TEST(CFXDIBitmapTest, UnPreMultiplyFromCleared) {
   auto bitmap = pdfium::MakeRetain<CFX_DIBitmap>();
   ASSERT_TRUE(bitmap->Create(1, 1, FXDIB_Format::kArgb));
   UNSAFE_TODO(FXARGB_SetDIB(bitmap->GetWritableBuffer().data(), 0x7f'7f'7f'7f));
@@ -128,7 +128,7 @@
   EXPECT_THAT(bitmap->GetBuffer(), ElementsAre(0xff, 0xff, 0xff, 0x7f));
 }
 
-TEST(CFX_DIBitmap, UnPreMultiply_FromPreMultiplied) {
+TEST(CFXDIBitmapTest, UnPreMultiplyFromPreMultiplied) {
   auto bitmap = pdfium::MakeRetain<CFX_DIBitmap>();
   ASSERT_TRUE(bitmap->Create(1, 1, FXDIB_Format::kArgb));
   bitmap->ForcePreMultiply();
@@ -138,7 +138,7 @@
   EXPECT_THAT(bitmap->GetBuffer(), ElementsAre(0xff, 0xff, 0xff, 0x7f));
 }
 
-TEST(CFX_DIBitmap, UnPreMultiply_FromUnPreMultiplied) {
+TEST(CFXDIBitmapTest, UnPreMultiplyFromUnPreMultiplied) {
   auto bitmap = pdfium::MakeRetain<CFX_DIBitmap>();
   ASSERT_TRUE(bitmap->Create(1, 1, FXDIB_Format::kArgb));
   bitmap->UnPreMultiply();