commit fd17f2f5f3d604a43c7c7273f9abb3577e108755
author Tom Sepez <tsepez@chromium.org> Mon Jun 16 15:03:17 2025 -0700
committer Pdfium LUCI CQ <pdfium-scoped@luci-project-accounts.iam.gserviceaccount.com> Mon Jun 16 15:03:17 2025 -0700
tree 38f40ff4589737d175ebcc52187b39a2f4fc7c2a
parent 06efa03997bcbd44e6de7483c5669fbde367a4a6

Fix UNSAFE_TODO() in BC_OnedCode128Writer_unittest.cpp.

Apply first() to a deduced span rather than using two-arg constructor.

Change-Id: Id9882b0f0ed03bdc406a7e1851907468609343bd
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/133292
Commit-Queue: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>

fxbarcode/oned/BC_OnedCode128Writer_unittest.cpp

diff --git a/fxbarcode/oned/BC_OnedCode128Writer_unittest.cpp b/fxbarcode/oned/BC_OnedCode128Writer_unittest.cpp
index 7905093..1d2a197 100644
--- a/fxbarcode/oned/BC_OnedCode128Writer_unittest.cpp
+++ b/fxbarcode/oned/BC_OnedCode128Writer_unittest.cpp
@@ -6,7 +6,6 @@
 
 #include <iterator>
 
-#include "core/fxcrt/compiler_specific.h"
 #include "core/fxcrt/span.h"
 #include "testing/gmock/include/gmock/gmock.h"
 #include "testing/gtest/include/gtest/gtest.h"
@@ -17,7 +16,7 @@
 
 struct TestCase {
   pdfium::span<const int32_t> pattern_span() const {
-    return UNSAFE_TODO(pdfium::span(patterns, num_patterns));
+    return pdfium::span(patterns).first(num_patterns);
   }
 
   const char* input;