commit fd6531fb3e7af170950fc581e67a299855027527
author Lei Zhang <thestig@chromium.org> Wed Feb 12 10:10:54 2025 -0800
committer Pdfium LUCI CQ <pdfium-scoped@luci-project-accounts.iam.gserviceaccount.com> Wed Feb 12 10:10:54 2025 -0800
tree 95b565d3d6d737a4722c79cd4a51e61d96427b63
parent ae69e3abdabf94db1e99f8cf97d5c50723b87bd4

Remove unused CFX_Face::GetHeight()

Delete this method, since https://pdfium-review.googlesource.com/114774
deleted the only caller.

Change-Id: I6bb6095918286f03bfcc1436e4e55944313d264c
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/128771
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Thomas Sepez <tsepez@google.com>

core/fxge/cfx_face.cpp

diff --git a/core/fxge/cfx_face.cpp b/core/fxge/cfx_face.cpp
index afff1ad..bd93d80 100644
--- a/core/fxge/cfx_face.cpp
+++ b/core/fxge/cfx_face.cpp
@@ -375,12 +375,6 @@
   return pdfium::checked_cast<int16_t>(GetRec()->descender);
 }
 
-#if BUILDFLAG(IS_ANDROID)
-int16_t CFX_Face::GetHeight() const {
-  return pdfium::checked_cast<int16_t>(GetRec()->height);
-}
-#endif
-
 pdfium::span<uint8_t> CFX_Face::GetData() const {
   // TODO(tsepez): justify safety from library API.
   return UNSAFE_BUFFERS(

core/fxge/cfx_face.h

diff --git a/core/fxge/cfx_face.h b/core/fxge/cfx_face.h
index ffbec18..cb6d0a4 100644
--- a/core/fxge/cfx_face.h
+++ b/core/fxge/cfx_face.h
@@ -67,9 +67,6 @@
   uint16_t GetUnitsPerEm() const;
   int16_t GetAscender() const;
   int16_t GetDescender() const;
-#if BUILDFLAG(IS_ANDROID)
-  int16_t GetHeight() const;
-#endif
 
   pdfium::span<uint8_t> GetData() const;