commit 5a6a8741b0e111a6b5bd9ab4e1036377c98885dc
author Igor Sheludko <ishell@chromium.org> Sat Jun 22 23:12:39 2024 +0000
committer Pdfium LUCI CQ <pdfium-scoped@luci-project-accounts.iam.gserviceaccount.com> Sat Jun 22 23:12:39 2024 +0000
tree 35136e70151c9a9746859d737484cc6e59b786e2
parent c0c4dcd4010f97bbeaf6746f0d09b9c644fc708a

Fix how NamedPropertySetterCallback returns result

V8 will prohibit calling ReturnValue<void>::Set(Local<S>) which used
to indicate whether the request was intercepted while the value was
not relevant. With the new interceptor Api the callback explicitly
returns v8::Intercepted::kYes/kNo and calling Set just for that is
not necessary.

Bug: 348660658
Change-Id: I960efb682bdab45a288e965d887dbdb7aff32433
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/120870
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Thomas Sepez <tsepez@google.com>

fxjs/cjs_global.cpp

diff --git a/fxjs/cjs_global.cpp b/fxjs/cjs_global.cpp
index dd0e271..79a89a6 100644
--- a/fxjs/cjs_global.cpp
+++ b/fxjs/cjs_global.cpp
@@ -118,8 +118,6 @@
         JSFormatErrorString("global", "PutProperty", result.Error()));
     return v8::Intercepted::kYes;
   }
-
-  info.GetReturnValue().Set(value);
   return v8::Intercepted::kYes;
 }
 

fxjs/xfa/cfxjse_class.cpp

diff --git a/fxjs/xfa/cfxjse_class.cpp b/fxjs/xfa/cfxjse_class.cpp
index adb3d48..0397cc2 100644
--- a/fxjs/xfa/cfxjse_class.cpp
+++ b/fxjs/xfa/cfxjse_class.cpp
@@ -252,7 +252,6 @@
   auto pNewValue = std::make_unique<CFXJSE_Value>(info.GetIsolate(), value);
   DynPropSetterAdapter(info.GetIsolate(), pClass, info.Holder(), szFxPropName,
                        pNewValue.get());
-  info.GetReturnValue().Set(value);
   return v8::Intercepted::kYes;
 }