commit 02b65d5adb81563799cf18a92da4506c5637696a
author Lei Zhang <thestig@chromium.org> Wed Dec 05 22:39:10 2018 +0000
committer Chromium commit bot <commit-bot@chromium.org> Wed Dec 05 22:39:10 2018 +0000
tree 4afeba278711d27e18ab06716137949263e03955
parent bf0e6aced17d72c94d06eb025d8ac687e9b114c2

Fix some nits in CXFA_LocaleValue.

Change-Id: I25d32a1bd0c96b00db357f270425cdd8f4845674
Reviewed-on: https://pdfium-review.googlesource.com/c/46551
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>

xfa/fxfa/parser/cxfa_localevalue.cpp

diff --git a/xfa/fxfa/parser/cxfa_localevalue.cpp b/xfa/fxfa/parser/cxfa_localevalue.cpp
index d74010d..cc9b205 100644
--- a/xfa/fxfa/parser/cxfa_localevalue.cpp
+++ b/xfa/fxfa/parser/cxfa_localevalue.cpp
@@ -267,9 +267,8 @@
   std::vector<WideString> wsPatterns;
   pFormat->SplitFormatString(wsFormat, &wsPatterns);
   wsResult.clear();
-  int32_t iCount = pdfium::CollectionSize<int32_t>(wsPatterns);
-  for (int32_t i = 0; i < iCount; i++) {
-    if (FormatSinglePattern(wsResult, wsPatterns[i], pLocale, eValueType))
+  for (const auto& pattern : wsPatterns) {
+    if (FormatSinglePattern(wsResult, pattern, pLocale, eValueType))
       return true;
   }
   return false;

xfa/fxfa/parser/cxfa_localevalue.h

diff --git a/xfa/fxfa/parser/cxfa_localevalue.h b/xfa/fxfa/parser/cxfa_localevalue.h
index c6f9c1e..2005905 100644
--- a/xfa/fxfa/parser/cxfa_localevalue.h
+++ b/xfa/fxfa/parser/cxfa_localevalue.h
@@ -59,7 +59,7 @@
                            LocaleIface* pLocale);
 
   bool IsValid() const { return m_bValid; }
-  WideString GetValue() const { return m_wsValue; }
+  const WideString& GetValue() const { return m_wsValue; }
   uint32_t GetType() const { return m_dwType; }
   double GetDoubleNum() const;
   bool SetDate(const CFX_DateTime& d);