commit 06a51b1ff4ab9e2a86e7e51e5123ccd49547ad8b
author Lei Zhang <thestig@chromium.org> Thu Sep 24 23:27:33 2020 +0000
committer Chromium commit bot <commit-bot@chromium.org> Thu Sep 24 23:27:33 2020 +0000
tree e3a6590f411a0635285ba958b4d4cb49f8827f2e
parent 231308b1feb7951f8a2436da04c1c02374598ad4

Remove a parameter from CJX_Object::SetAttributeByString().

It only has 1 caller and the callers always passes in true.

Change-Id: Iba975cf54d3b0932ae70d8539eca37e9682ed122
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/74070
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>

fxjs/xfa/cjx_node.cpp

diff --git a/fxjs/xfa/cjx_node.cpp b/fxjs/xfa/cjx_node.cpp
index 63ed675..0efb693 100644
--- a/fxjs/xfa/cjx_node.cpp
+++ b/fxjs/xfa/cjx_node.cpp
@@ -434,8 +434,7 @@
   WideString attribute = runtime->ToWideString(params[1]);
 
   // Pass them to our method, however, in the more usual manner.
-  SetAttributeByString(attribute.AsStringView(), attributeValue.AsStringView(),
-                       true);
+  SetAttributeByString(attribute.AsStringView(), attributeValue.AsStringView());
   return CJS_Result::Success();
 }
 

fxjs/xfa/cjx_object.cpp

diff --git a/fxjs/xfa/cjx_object.cpp b/fxjs/xfa/cjx_object.cpp
index a4a7f5c..fac1c1e 100644
--- a/fxjs/xfa/cjx_object.cpp
+++ b/fxjs/xfa/cjx_object.cpp
@@ -265,11 +265,10 @@
 }
 
 void CJX_Object::SetAttributeByString(WideStringView wsAttr,
-                                      WideStringView wsValue,
-                                      bool bNotify) {
+                                      WideStringView wsValue) {
   Optional<XFA_ATTRIBUTEINFO> attr = XFA_GetAttributeByName(wsAttr);
   if (attr.has_value()) {
-    SetAttributeByEnum(attr.value().attribute, wsValue, bNotify);
+    SetAttributeByEnum(attr.value().attribute, wsValue, true);
     return;
   }
   void* pKey = GetMapKey_Custom(wsAttr);

fxjs/xfa/cjx_object.h

diff --git a/fxjs/xfa/cjx_object.h b/fxjs/xfa/cjx_object.h
index c54d666..0dd4b32 100644
--- a/fxjs/xfa/cjx_object.h
+++ b/fxjs/xfa/cjx_object.h
@@ -141,9 +141,7 @@
   void SetAttributeByEnum(XFA_Attribute eAttr,
                           WideStringView wsValue,
                           bool bNotify);
-  void SetAttributeByString(WideStringView wsAttr,
-                            WideStringView wsValue,
-                            bool bNotify);
+  void SetAttributeByString(WideStringView wsAttr, WideStringView wsValue);
   void RemoveAttribute(WideStringView wsAttr);
   WideString GetAttributeByString(WideStringView attr);
   WideString GetAttributeByEnum(XFA_Attribute attr);