commit 07835bd3bec8174ed71b2114d7191aeda8cfe283
author Omer Katz <omerkatz@chromium.org> Thu Jun 24 22:25:32 2021 +0000
committer Pdfium LUCI CQ <pdfium-scoped@luci-project-accounts.iam.gserviceaccount.com> Thu Jun 24 22:25:32 2021 +0000
tree b89589c55897a7fb02984f5f0d1a952e7558a536
parent 300219c0bf6d5d4170afb3708eb5cb97ebc50ed3

Fix clang pc plugin warnings

Bug: chromium:1056170
Change-Id: Ifd93017bb4070573ed086ff22bde28029db7bb87
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/82370
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>

xfa/fxfa/cxfa_ffdocview.cpp

diff --git a/xfa/fxfa/cxfa_ffdocview.cpp b/xfa/fxfa/cxfa_ffdocview.cpp
index 4e007b4..e04e69c 100644
--- a/xfa/fxfa/cxfa_ffdocview.cpp
+++ b/xfa/fxfa/cxfa_ffdocview.cpp
@@ -532,7 +532,7 @@
   if (!pGlobalData)
     return;
 
-  for (auto pResult : pGlobalData->m_Globals) {
+  for (auto& pResult : pGlobalData->m_Globals) {
     if (!pResult->HasRemovedChildren() && pResult->IsWidgetReady())
       AddCalculateNode(pResult);
   }

xfa/fxfa/cxfa_ffpageview.cpp

diff --git a/xfa/fxfa/cxfa_ffpageview.cpp b/xfa/fxfa/cxfa_ffpageview.cpp
index 527acfe..7a49aaf 100644
--- a/xfa/fxfa/cxfa_ffpageview.cpp
+++ b/xfa/fxfa/cxfa_ffpageview.cpp
@@ -161,13 +161,8 @@
   CXFA_TabParam& operator=(const CXFA_TabParam&) = delete;
   CXFA_TabParam& operator=(CXFA_TabParam&&) noexcept = default;
 
-  void Trace(cppgc::Visitor* visitor) const {
-    visitor->Trace(m_pItem);
-    ContainerTrace(visitor, m_Children);
-  }
-
   CXFA_FFWidget* GetWidget() const { return m_pItem->GetFFWidget(); }
-  const std::vector<cppgc::Member<CXFA_ContentLayoutItem>>& GetChildren()
+  const std::vector<cppgc::Persistent<CXFA_ContentLayoutItem>>& GetChildren()
       const {
     return m_Children;
   }
@@ -179,8 +174,8 @@
   }
 
  private:
-  cppgc::Member<CXFA_ContentLayoutItem> m_pItem;
-  std::vector<cppgc::Member<CXFA_ContentLayoutItem>> m_Children;
+  cppgc::Persistent<CXFA_ContentLayoutItem> m_pItem;
+  std::vector<cppgc::Persistent<CXFA_ContentLayoutItem>> m_Children;
 };
 
 void OrderContainer(CXFA_LayoutItemIterator* sIterator,