commit 0969211eb6db88d33cf4a54ca2c51d3f28be5fab
author Hui Yingst <nigi@chromium.org> Fri Sep 30 19:46:27 2022 +0000
committer Pdfium LUCI CQ <pdfium-scoped@luci-project-accounts.iam.gserviceaccount.com> Fri Sep 30 19:46:27 2022 +0000
tree 2d78e68aff74ce63fca7d99acd59c0076c513e04
parent 9fe1590090fce3e3d5bdf077c7ec452ffee2e5d1

Enable FPDFEditEmbedderTest.SaveAndRender for Skia

CL[1] fixed the issue that paths with transparent fill and stroke
colors are rendered with overlapping area of the two colors and the
Skia rendering result for FPDFEditEmbedderTest.SaveAndRender is now
acceptable.

This CL adds the Skia expectation for this test so that it can be
enabled.

[1] https://pdfium-review.googlesource.com/97350

Bug: pdfium:1651
Change-Id: Ide89e8f1c6c5d22bdac90f6649b15bb5df2a68f1
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/98631
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Nigi <nigi@chromium.org>

fpdfsdk/fpdf_edit_embeddertest.cpp

diff --git a/fpdfsdk/fpdf_edit_embeddertest.cpp b/fpdfsdk/fpdf_edit_embeddertest.cpp
index bb910bc..82926b0 100644
--- a/fpdfsdk/fpdf_edit_embeddertest.cpp
+++ b/fpdfsdk/fpdf_edit_embeddertest.cpp
@@ -3181,15 +3181,11 @@
 }
 #endif  // BUILDFLAG(IS_LINUX) || BUILDFLAG(IS_CHROMEOS)
 
-// TODO(crbug.com/pdfium/1651): Fix this issue and enable the test for Skia.
-#if defined(_SKIA_SUPPORT_)
-#define MAYBE_SaveAndRender DISABLED_SaveAndRender
-#else
-#define MAYBE_SaveAndRender SaveAndRender
-#endif
-TEST_F(FPDFEditEmbedderTest, MAYBE_SaveAndRender) {
+TEST_F(FPDFEditEmbedderTest, SaveAndRender) {
   const char* checksum = []() {
-    if (CFX_DefaultRenderDevice::SkiaVariantIsDefaultRenderer())
+    if (CFX_DefaultRenderDevice::SkiaIsDefaultRenderer())
+      return "9a78649e85e69d220c22e0fc316da740";
+    if (CFX_DefaultRenderDevice::SkiaPathsIsDefaultRenderer())
       return "0e8b079e349e34f64211c495845a3529";
     return "3c20472b0552c0c22b88ab1ed8c6202b";
   }();