commit 0c6b98182403868334b4dfe4852caa4d0e2ba272
author Ryan Harrison <rharrison@chromium.org> Mon Mar 12 19:25:55 2018 +0000
committer Chromium commit bot <commit-bot@chromium.org> Mon Mar 12 19:25:55 2018 +0000
tree d336db128fee55372ae35306f8d418e5b0ac7d1b
parent 83a01491dbd91e31c9d9417b8b975259a0fb3aec

Remove all usages of FXSYS_iswASCIIspace

This replaces it with FXSYS_iswspace, which uses ICU to perform
correct Unicode space checking.

BUG=pdfium:1035

Change-Id: I7a4ed01a6b50f56a6f9d1434a7f0b01596fe42db
Reviewed-on: https://pdfium-review.googlesource.com/28510
Reviewed-by: dsinclair <dsinclair@chromium.org>
Commit-Queue: Ryan Harrison <rharrison@chromium.org>

core/fxcrt/fx_extension.h

diff --git a/core/fxcrt/fx_extension.h b/core/fxcrt/fx_extension.h
index fd7b78a..8e9d066 100644
--- a/core/fxcrt/fx_extension.h
+++ b/core/fxcrt/fx_extension.h
@@ -50,8 +50,8 @@
   return u_isalnum(c);
 }
 
-inline bool FXSYS_iswASCIIspace(wchar_t c) {
-  return (c == 0x20) || (c == 0x0d) || (c == 0x0a) || (c == 0x09);
+inline bool FXSYS_iswspace(wchar_t c) {
+  return u_isspace(c);
 }
 
 inline bool FXSYS_isHexDigit(const char c) {

core/fxge/dib/fx_dib_main.cpp

diff --git a/core/fxge/dib/fx_dib_main.cpp b/core/fxge/dib/fx_dib_main.cpp
index f0767f3..68e06a6 100644
--- a/core/fxge/dib/fx_dib_main.cpp
+++ b/core/fxge/dib/fx_dib_main.cpp
@@ -97,7 +97,7 @@
   int cc = 0;
   const wchar_t* str = wsValue.unterminated_c_str();
   int len = wsValue.GetLength();
-  while (FXSYS_iswASCIIspace(str[cc]) && cc < len)
+  while (FXSYS_iswspace(str[cc]) && cc < len)
     cc++;
 
   if (cc >= len)
@@ -112,7 +112,7 @@
   }
   if (cc < len && str[cc] == ',') {
     cc++;
-    while (FXSYS_iswASCIIspace(str[cc]) && cc < len)
+    while (FXSYS_iswspace(str[cc]) && cc < len)
       cc++;
 
     while (cc < len) {
@@ -124,7 +124,7 @@
     }
     if (cc < len && str[cc] == ',') {
       cc++;
-      while (FXSYS_iswASCIIspace(str[cc]) && cc < len)
+      while (FXSYS_iswspace(str[cc]) && cc < len)
         cc++;
 
       while (cc < len) {

xfa/fxfa/parser/cxfa_localevalue.cpp

diff --git a/xfa/fxfa/parser/cxfa_localevalue.cpp b/xfa/fxfa/parser/cxfa_localevalue.cpp
index 57d6fbb..8ef67e5 100644
--- a/xfa/fxfa/parser/cxfa_localevalue.cpp
+++ b/xfa/fxfa/parser/cxfa_localevalue.cpp
@@ -202,7 +202,7 @@
     bool bExpSign = false;
     const wchar_t* str = m_wsValue.c_str();
     int len = m_wsValue.GetLength();
-    while (FXSYS_iswASCIIspace(str[cc]) && cc < len)
+    while (FXSYS_iswspace(str[cc]) && cc < len)
       cc++;
 
     if (cc >= len)