Fix gclient sync noise for clang-format
Updates the gclient hooks for clang-format from Chromium's. The updated
rules filter on the host_os condition, avoiding noise when running
download_from_google_storage with the wrong platform.
Change-Id: I43439261816fb941289260fb303ba1dc107b0afc
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/69191
Commit-Queue: K Moon <kmoon@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Auto-Submit: K Moon <kmoon@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
diff --git a/DEPS b/DEPS
index 08f22ec..8bd692e 100644
--- a/DEPS
+++ b/DEPS
@@ -253,13 +253,14 @@
'pattern': '.',
'action': ['python', 'pdfium/build/mac_toolchain.py'],
},
+ # Pull clang-format binaries using checked-in hashes.
{
- # Pull clang-format binaries using checked-in hashes.
'name': 'clang_format_win',
'pattern': '.',
- 'action': [ 'download_from_google_storage',
+ 'condition': 'host_os == "win"',
+ 'action': [ 'python',
+ 'pdfium/third_party/depot_tools/download_from_google_storage.py',
'--no_resume',
- '--platform=win32',
'--no_auth',
'--bucket', 'chromium-clang-format',
'-s', 'pdfium/buildtools/win/clang-format.exe.sha1',
@@ -268,9 +269,10 @@
{
'name': 'clang_format_mac',
'pattern': '.',
- 'action': [ 'download_from_google_storage',
+ 'condition': 'host_os == "mac"',
+ 'action': [ 'python',
+ 'pdfium/third_party/depot_tools/download_from_google_storage.py',
'--no_resume',
- '--platform=darwin',
'--no_auth',
'--bucket', 'chromium-clang-format',
'-s', 'pdfium/buildtools/mac/clang-format.sha1',
@@ -279,9 +281,10 @@
{
'name': 'clang_format_linux',
'pattern': '.',
- 'action': [ 'download_from_google_storage',
+ 'condition': 'host_os == "linux"',
+ 'action': [ 'python',
+ 'pdfium/third_party/depot_tools/download_from_google_storage.py',
'--no_resume',
- '--platform=linux*',
'--no_auth',
'--bucket', 'chromium-clang-format',
'-s', 'pdfium/buildtools/linux64/clang-format.sha1',
