commit 0fcb28e0816bea59cb28a4e2dfaf7bc0e4a184b8
author Lei Zhang <thestig@chromium.org> Sat Jan 14 00:37:44 2023 +0000
committer Pdfium LUCI CQ <pdfium-scoped@luci-project-accounts.iam.gserviceaccount.com> Sat Jan 14 00:37:44 2023 +0000
tree 8a93e49f28ca5066146bc97bcc9675b32b2de764
parent 640a741713523ef4f3883d5d13126263732acf59

Fix some nits in fx_skia_device.cpp.

- Remove unnecessary use of `this->`.
- Rename nearby variables to follow the style guide.

Change-Id: I898cd38c3170680f070a8a18b6e58d6f8d1e1375
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/103232
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Nigi <nigi@chromium.org>

core/fxge/skia/fx_skia_device.cpp

diff --git a/core/fxge/skia/fx_skia_device.cpp b/core/fxge/skia/fx_skia_device.cpp
index 0e9c20f..cf4040c 100644
--- a/core/fxge/skia/fx_skia_device.cpp
+++ b/core/fxge/skia/fx_skia_device.cpp
@@ -2007,55 +2007,55 @@
 }
 
 void CFX_DIBitmap::PreMultiply() {
-  if (this->GetBPP() != 32)
+  if (GetBPP() != 32)
     return;
 
-  void* buffer = this->GetBuffer().data();
+  void* buffer = GetBuffer().data();
   if (!buffer)
     return;
 
-  Format priorFormat = m_nFormat;
+  Format prior_format = m_nFormat;
   m_nFormat = Format::kPreMultiplied;
-  if (priorFormat == Format::kPreMultiplied)
+  if (prior_format == Format::kPreMultiplied)
     return;
 
-  int height = this->GetHeight();
-  int width = this->GetWidth();
-  int rowBytes = this->GetPitch();
-  SkImageInfo unpremultipliedInfo =
+  int height = GetHeight();
+  int width = GetWidth();
+  int row_bytes = GetPitch();
+  SkImageInfo unpremultiplied_info =
       SkImageInfo::Make(width, height, kN32_SkColorType, kUnpremul_SkAlphaType);
-  SkPixmap unpremultiplied(unpremultipliedInfo, buffer, rowBytes);
-  SkImageInfo premultipliedInfo =
+  SkPixmap unpremultiplied(unpremultiplied_info, buffer, row_bytes);
+  SkImageInfo premultiplied_info =
       SkImageInfo::Make(width, height, kN32_SkColorType, kPremul_SkAlphaType);
-  SkPixmap premultiplied(premultipliedInfo, buffer, rowBytes);
+  SkPixmap premultiplied(premultiplied_info, buffer, row_bytes);
   unpremultiplied.readPixels(premultiplied);
-  this->DebugVerifyBitmapIsPreMultiplied();
+  DebugVerifyBitmapIsPreMultiplied();
 }
 
 void CFX_DIBitmap::UnPreMultiply() {
-  if (this->GetBPP() != 32)
+  if (GetBPP() != 32)
     return;
 
-  void* buffer = this->GetBuffer().data();
+  void* buffer = GetBuffer().data();
   if (!buffer)
     return;
 
-  Format priorFormat = m_nFormat;
+  Format prior_format = m_nFormat;
   m_nFormat = Format::kUnPreMultiplied;
 
-  if (priorFormat == Format::kUnPreMultiplied)
+  if (prior_format == Format::kUnPreMultiplied)
     return;
 
-  this->DebugVerifyBitmapIsPreMultiplied();
-  int height = this->GetHeight();
-  int width = this->GetWidth();
-  int rowBytes = this->GetPitch();
-  SkImageInfo premultipliedInfo =
+  DebugVerifyBitmapIsPreMultiplied();
+  int height = GetHeight();
+  int width = GetWidth();
+  int row_bytes = GetPitch();
+  SkImageInfo premultiplied_info =
       SkImageInfo::Make(width, height, kN32_SkColorType, kPremul_SkAlphaType);
-  SkPixmap premultiplied(premultipliedInfo, buffer, rowBytes);
-  SkImageInfo unpremultipliedInfo =
+  SkPixmap premultiplied(premultiplied_info, buffer, row_bytes);
+  SkImageInfo unpremultiplied_info =
       SkImageInfo::Make(width, height, kN32_SkColorType, kUnpremul_SkAlphaType);
-  SkPixmap unpremultiplied(unpremultipliedInfo, buffer, rowBytes);
+  SkPixmap unpremultiplied(unpremultiplied_info, buffer, row_bytes);
   premultiplied.readPixels(unpremultiplied);
 }