commit 118cb104188f4d26defed31cf6f2764375f3c61d
author Tom Sepez <tsepez@chromium.org> Wed May 04 21:59:42 2022 +0000
committer Pdfium LUCI CQ <pdfium-scoped@luci-project-accounts.iam.gserviceaccount.com> Wed May 04 21:59:42 2022 +0000
tree c8f2347de59f1c89e67cec9aeddf63b5b27c6d90
parent 3a3aff3e901d8073b1d0d3ab9de7a742d6692f13

Run non-JS /OpenAction even if JS not present.

Very curious since it has been this way since before the
beginning. Might have been cut/paste from previous method
which invoked a JS action, but seems like OpenAction should
not be predicated on that.

Unfortunately, the test harness isn't equipped to deal with
the consequence of this change. The follow-on CL, however,
requires it and will enforce behaviour.

Change-Id: I475e4b6bb11045918cd2b6b3b0185ef6fc25e40b
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/93370
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Tom Sepez <tsepez@chromium.org>

fpdfsdk/fpdf_formfill.cpp

diff --git a/fpdfsdk/fpdf_formfill.cpp b/fpdfsdk/fpdf_formfill.cpp
index 7fb9733..91c0274 100644
--- a/fpdfsdk/fpdf_formfill.cpp
+++ b/fpdfsdk/fpdf_formfill.cpp
@@ -756,7 +756,7 @@
 FORM_DoDocumentOpenAction(FPDF_FORMHANDLE hHandle) {
   CPDFSDK_FormFillEnvironment* pFormFillEnv =
       CPDFSDKFormFillEnvironmentFromFPDFFormHandle(hHandle);
-  if (pFormFillEnv && pFormFillEnv->IsJSPlatformPresent())
+  if (pFormFillEnv)
     pFormFillEnv->ProcOpenAction();
 }
 

testing/SUPPRESSIONS

diff --git a/testing/SUPPRESSIONS b/testing/SUPPRESSIONS
index 72f3c77..6151eaa 100644
--- a/testing/SUPPRESSIONS
+++ b/testing/SUPPRESSIONS
@@ -317,6 +317,10 @@
 # TODO(v8:12806) Fix regression and remove this suppression.
 globals.in * * * *
 
+# JS tests in nov8 mode expect empty results. This one will
+# not be empty as the callback is not js-based.
+named_action.in * nov8 * *
+
 # xfa_specific
 
 # TODO(pdfium:1106): Remove after associated bug is fixed