commit 1885f187fe39071fa857274867ff811b2237ab34
author Tom Sepez <tsepez@chromium.org> Mon May 16 18:06:20 2022 +0000
committer Pdfium LUCI CQ <pdfium-scoped@luci-project-accounts.iam.gserviceaccount.com> Mon May 16 18:06:20 2022 +0000
tree 3da28a346ceb5732f1f7fc7eb9c5340856005748
parent 3f417878aadef3d6976a504190bfc3ac35468b9d

Do not invoke V8 CPPCG after heap destroyed in tests

This is a bug in the pdfium_test harness where a V8 cppgc message
loop may be pumped after the heap is destroyed (by the scoped document
going out of scope at the end of ProcessPdf(). We've already idled the
loop to emptyness at line 1136, so there's no need after return.

Bug: chromium:1325664
Change-Id: I34d5a82551789d6359dbb7a58185bb9ff83d6629
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/93730
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Tom Sepez <tsepez@chromium.org>

samples/pdfium_test.cc

diff --git a/samples/pdfium_test.cc b/samples/pdfium_test.cc
index 2c76808..5703d83 100644
--- a/samples/pdfium_test.cc
+++ b/samples/pdfium_test.cc
@@ -1378,7 +1378,6 @@
 
     ProcessPdf(filename, file_contents.get(), file_length, options, events,
                idler);
-    idler();
 
 #ifdef ENABLE_CALLGRIND
     if (options.callgrind_delimiters)