commit 1902547b8ed29a26137e34204fe7fb9701bf8ef3
author Lei Zhang <thestig@chromium.org> Tue Oct 29 23:27:28 2019 +0000
committer Chromium commit bot <commit-bot@chromium.org> Tue Oct 29 23:27:28 2019 +0000
tree fa1ec454fe020087f5643f19949bb85dd5edf93a
parent bec0bcd0db7d9fddf16c936cca18526abb2525cf

Properly handle seek failure in CFX_BmpDecompressor::ReadBmpHeader().

Now the ReadBmpHeader() returns BmpModule::Status instead of a bool, it
is more obvious that |kContinue| is not the right return value for a
seek failure. Return |kFail| instead.

Change-Id: Ib06ea5b432badcaf60e9bef1706bd53abb325701
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/61730
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>

core/fxcodec/bmp/cfx_bmpdecompressor.cpp

diff --git a/core/fxcodec/bmp/cfx_bmpdecompressor.cpp b/core/fxcodec/bmp/cfx_bmpdecompressor.cpp
index 682c68f..d287aad 100644
--- a/core/fxcodec/bmp/cfx_bmpdecompressor.cpp
+++ b/core/fxcodec/bmp/cfx_bmpdecompressor.cpp
@@ -107,7 +107,7 @@
     return BmpModule::Status::kContinue;
   }
   if (!input_buffer_->Seek(pos))
-    return BmpModule::Status::kContinue;
+    return BmpModule::Status::kFail;
 
   img_ifh_size_ =
       FXDWORD_GET_LSBFIRST(reinterpret_cast<uint8_t*>(&img_ifh_size_));