commit 1994b83a995332531e94489e37638e819bd8a8b7
author Lei Zhang <thestig@chromium.org> Fri Aug 06 18:54:10 2021 +0000
committer Pdfium LUCI CQ <pdfium-scoped@luci-project-accounts.iam.gserviceaccount.com> Fri Aug 06 18:54:10 2021 +0000
tree 4c8a7053a8d05224aa8b0b002d312e14ca5b06f6
parent 6700e54aeb991bef28a1ed2f6534ee5b60fc9f44

Change CFX_PSRenderer::StartRendering() return type to void.

- It always returns true.
- No caller checks the return value.
- Also rename a constant in StartRendering() to kFoo.

Change-Id: Id44c396ac114b4fb89ea6c1c549ff7a92d09f76e
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/83956
Commit-Queue: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>

core/fxge/win32/cfx_psrenderer.cpp

diff --git a/core/fxge/win32/cfx_psrenderer.cpp b/core/fxge/win32/cfx_psrenderer.cpp
index ed07532..066cdf2 100644
--- a/core/fxge/win32/cfx_psrenderer.cpp
+++ b/core/fxge/win32/cfx_psrenderer.cpp
@@ -56,11 +56,11 @@
   m_ClipBox.bottom = height;
 }
 
-bool CFX_PSRenderer::StartRendering() {
+void CFX_PSRenderer::StartRendering() {
   if (m_bInited)
-    return true;
+    return;
 
-  static const char init_str[] =
+  static const char kInitStr[] =
       "\nsave\n/im/initmatrix load def\n"
       "/n/newpath load def/m/moveto load def/l/lineto load def/c/curveto load "
       "def/h/closepath load def\n"
@@ -74,9 +74,8 @@
       "load def\n"
       "/cm/concat load def/Cm/currentmatrix load def/mx/matrix load "
       "def/sm/setmatrix load def\n";
-  m_pStream->WriteString(init_str);
+  m_pStream->WriteString(kInitStr);
   m_bInited = true;
-  return true;
 }
 
 void CFX_PSRenderer::EndRendering() {

core/fxge/win32/cfx_psrenderer.h

diff --git a/core/fxge/win32/cfx_psrenderer.h b/core/fxge/win32/cfx_psrenderer.h
index 74d194e..8e22045 100644
--- a/core/fxge/win32/cfx_psrenderer.h
+++ b/core/fxge/win32/cfx_psrenderer.h
@@ -61,7 +61,7 @@
             int pslevel,
             int width,
             int height);
-  bool StartRendering();
+  void StartRendering();
   void EndRendering();
   void SaveState();
   void RestoreState(bool bKeepSaved);