commit 1f0b692d546eaf21182131f6ca56c302608270ab
author Lei Zhang <thestig@chromium.org> Fri Dec 16 23:52:33 2022 +0000
committer Pdfium LUCI CQ <pdfium-scoped@luci-project-accounts.iam.gserviceaccount.com> Fri Dec 16 23:52:33 2022 +0000
tree 95da4932891fdc2f98aad0bdfaf4f8338276c11a
parent 5a8242d8b8b606a21fa64e066c65b3d0db432c64

Remove some ref churn in CFX_DefaultRenderDevice::AttachImpl().

Use std::move() on more bitmaps.

Change-Id: I8980cb9a42efcac701ca7f3a1e0669d8db995f22
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/102771
Reviewed-by: Nigi <nigi@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>

core/fxge/cfx_defaultrenderdevice.cpp

diff --git a/core/fxge/cfx_defaultrenderdevice.cpp b/core/fxge/cfx_defaultrenderdevice.cpp
index 912db62..fc61b58 100644
--- a/core/fxge/cfx_defaultrenderdevice.cpp
+++ b/core/fxge/cfx_defaultrenderdevice.cpp
@@ -69,11 +69,12 @@
     bool bGroupKnockout) {
 #ifdef _SKIA_SUPPORT_
   if (SkiaIsDefaultRenderer()) {
-    return AttachSkiaImpl(pBitmap, bRgbByteOrder, pBackdropBitmap,
-                          bGroupKnockout);
+    return AttachSkiaImpl(std::move(pBitmap), bRgbByteOrder,
+                          std::move(pBackdropBitmap), bGroupKnockout);
   }
 #endif
-  return AttachAggImpl(pBitmap, bRgbByteOrder, pBackdropBitmap, bGroupKnockout);
+  return AttachAggImpl(std::move(pBitmap), bRgbByteOrder,
+                       std::move(pBackdropBitmap), bGroupKnockout);
 }
 
 bool CFX_DefaultRenderDevice::Create(int width,