commit 20c5215096e91c32ae8663d4c47d90ecc3b4da2b
author Lei Zhang <thestig@chromium.org> Fri Jun 18 20:37:10 2021 +0000
committer Pdfium LUCI CQ <pdfium-scoped@luci-project-accounts.iam.gserviceaccount.com> Fri Jun 18 20:37:10 2021 +0000
tree d7271419561341a86aee55089d63ca4a0d2145cc
parent 61359deb8b958db85b1935e2aa297d4bb5daa58e

Add FPDFEditEmbedderTest.AddStandardFontTextOfSizeZero.

Show that FPDFPageObj_NewTextObj() can create a text object with font
size 0, and that FPDFTextObj_GetFontSize() has an ambiguous return value
when called on the newly created object.

Bug: pdfium:1695
Change-Id: Ib0a162e0fcde00e9c373bee2cb52987e667cf507
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/82197
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>

fpdfsdk/fpdf_edit_embeddertest.cpp

diff --git a/fpdfsdk/fpdf_edit_embeddertest.cpp b/fpdfsdk/fpdf_edit_embeddertest.cpp
index 5577a12..f60445b 100644
--- a/fpdfsdk/fpdf_edit_embeddertest.cpp
+++ b/fpdfsdk/fpdf_edit_embeddertest.cpp
@@ -2302,6 +2302,34 @@
   FPDF_ClosePage(page);
 }
 
+TEST_F(FPDFEditEmbedderTest, AddStandardFontTextOfSizeZero) {
+  // Start with a blank page
+  ScopedFPDFPage page(FPDFPage_New(CreateNewDocument(), 0, 612, 792));
+
+  // Add some text of size 0 to the page.
+  FPDF_PAGEOBJECT text_object =
+      FPDFPageObj_NewTextObj(document(), "Arial", 0.0f);
+  EXPECT_TRUE(text_object);
+  ScopedFPDFWideString text = GetFPDFWideString(kBottomText);
+  EXPECT_TRUE(FPDFText_SetText(text_object, text.get()));
+  FPDFPageObj_Transform(text_object, 1, 0, 0, 1, 20, 20);
+
+  // TODO(crbug.com/pdfium/1695): A return value of 0 is suppose to mean
+  // failure. Did FPDFTextObj_GetFontSize() fail here?
+  EXPECT_EQ(0.0f, FPDFTextObj_GetFontSize(text_object));
+
+  FPDFPage_InsertObject(page.get(), text_object);
+  EXPECT_TRUE(FPDFPage_GenerateContent(page.get()));
+  {
+    ScopedFPDFBitmap page_bitmap = RenderPage(page.get());
+    CompareBitmap(page_bitmap.get(), 612, 792,
+                  pdfium::kBlankPage612By792Checksum);
+
+    EXPECT_TRUE(FPDF_SaveAsCopy(document(), this, 0));
+    VerifySavedDocument(612, 792, pdfium::kBlankPage612By792Checksum);
+  }
+}
+
 TEST_F(FPDFEditEmbedderTest, GetTextRenderMode) {
   ASSERT_TRUE(OpenDocument("text_render_mode.pdf"));
   FPDF_PAGE page = LoadPage(0);