commit 22a617f93038e2b149afc422011781757d1a3b6e
author Lei Zhang <thestig@chromium.org> Wed Oct 31 17:57:35 2018 +0000
committer Chromium commit bot <commit-bot@chromium.org> Wed Oct 31 17:57:35 2018 +0000
tree 3c5e2045ffb153f01f82a93117782edc77336d81
parent bbeff733b2937135be15b1561f22e239a6f170b7

Roll third_party/skia/ 728b7f3cd..7258e97e8 (1 commit)

https://chromium.googlesource.com/skia.git/+log/728b7f3cdd0a..7258e97e8e3a

Skia now requires C++14. Update docs accordingly.

Created with:
  roll-dep third_party/skia

BUG=pdfium:11

Change-Id: I41398f1c55333c2a570961a789e426e65681d6a5
Reviewed-on: https://pdfium-review.googlesource.com/c/44950
Reviewed-by: Ben Wagner <bungeman@google.com>
Commit-Queue: Lei Zhang <thestig@chromium.org>

DEPS

diff --git a/DEPS b/DEPS
index db406c3..b492e80 100644
--- a/DEPS
+++ b/DEPS
@@ -30,7 +30,7 @@
   'jpeg_turbo_revision': '61a2bbaa9aec89cb2c882d87ace6aba9aee49bb9',
   'markupsafe_revision': '8f45f5cfa0009d2a70589bcda0349b8cb2b72783',
   'pdfium_tests_revision': '5a68e87859476eb75d3e068bd406c4921a6be8e2',
-  'skia_revision': '728b7f3cdd0ad6a76c10e45fc4a4a8f4c5208c6e',
+  'skia_revision': '7258e97e8e3af173cc5131f309ae487f663bfd39',
   'tools_memory_revision': 'f7b00daf4df7f6c469f5fbc68d7f40f6bd15d6e6',
   'trace_event_revision': '211b3ed9d0481b4caddbee1322321b86a483ca1f',
   'v8_revision': 'a4f6a37da361b69c87c9230152d8cfb8ce351428',

README.md

diff --git a/README.md b/README.md
index 0312fbc..f2f6adf 100644
--- a/README.md
+++ b/README.md
@@ -42,8 +42,9 @@
 Once you've done this, the toolchain will be installed automatically for
 you in the [Generate the build files](#GenBuild) step below.
 
-The toolchain will be in `depot_tools\win_toolchain\vs_files\<hash>`, and windbg
-can be found in `depot_tools\win_toolchain\vs_files\<hash>\win_sdk\Debuggers`.
+The toolchain will be in `depot_tools\win_toolchain\vs_files\<hash>`, and
+windbg can be found in
+`depot_tools\win_toolchain\vs_files\<hash>\win_sdk\Debuggers`.
 
 If you want the IDE for debugging and editing, you will need to install
 it separately, but this is optional and not needed for building PDFium.
@@ -89,8 +90,10 @@
 use_goma = true  # Googlers only. Make sure goma is installed and running first.
 is_debug = true  # Enable debugging features.
 
-pdf_use_skia = false  # Set true to enable experimental skia backend.
-pdf_use_skia_paths = false  # Set true to enable experimental skia backend (paths only).
+# Set true to enable experimental Skia backend.
+pdf_use_skia = false
+# Set true to enable experimental Skia backend (paths only).
+pdf_use_skia_paths = false
 
 pdf_enable_xfa = true  # Set false to remove XFA support (implies JS support).
 pdf_enable_v8 = true  # Set false to remove Javascript support.
@@ -100,8 +103,11 @@
 clang_use_chrome_plugins = false  # Currently must be false.
 ```
 
-Note, you must set `pdf_is_standalone = true` if you want the sample
-applications like `pdfium_test` to build.
+For sample applications like `pdfium_test` to build, one must set
+`pdf_is_standalone = true`.
+
+To use the Skia backend, one must set `use_cxx11 = false` which will build the
+entire project with C++14.
 
 When complete the arguments will be stored in `<directory>/args.gn`, and
 GN will automatically use the new arguments to generate build files.