commit 241934652494c6c967e0b8732401828a9995ed38
author Tom Sepez <tsepez@chromium.org> Mon Feb 03 18:01:29 2020 +0000
committer Chromium commit bot <commit-bot@chromium.org> Mon Feb 03 18:01:29 2020 +0000
tree 6ef2518ad3ef4f279fd7518b96130bb8b470e023
parent dc397e0a03e0a1f36b50bcc25ded030716387d4c

Tidy cpdfsdk_widget.h

- Make one method private.
- Group XFA-specific methods together
- Document classes to which overrides apply.

Change-Id: I25f1229b3e3f3e50f7af57981bf0fb0fd6f5093b
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/65874
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Tom Sepez <tsepez@chromium.org>

fpdfsdk/cpdfsdk_widget.h

diff --git a/fpdfsdk/cpdfsdk_widget.h b/fpdfsdk/cpdfsdk_widget.h
index d328b67..8214e08 100644
--- a/fpdfsdk/cpdfsdk_widget.h
+++ b/fpdfsdk/cpdfsdk_widget.h
@@ -43,27 +43,17 @@
 
 class CPDFSDK_Widget final : public CPDFSDK_BAAnnot {
  public:
-#ifdef PDF_ENABLE_XFA
-  CXFA_FFWidget* GetMixXFAWidget() const;
-  CXFA_FFWidgetHandler* GetXFAWidgetHandler() const;
-
-  bool HasXFAAAction(PDFSDK_XFAAActionType eXFAAAT) const;
-  bool OnXFAAAction(PDFSDK_XFAAActionType eXFAAAT,
-                    CPDFSDK_FieldAction* data,
-                    CPDFSDK_PageView* pPageView);
-
-  void Synchronize(bool bSynchronizeElse);
-#endif  // PDF_ENABLE_XFA
-
   CPDFSDK_Widget(CPDF_Annot* pAnnot,
                  CPDFSDK_PageView* pPageView,
                  CPDFSDK_InteractiveForm* pInteractiveForm);
   ~CPDFSDK_Widget() override;
 
+  // CPDFSDK_BAAnnot:
   bool IsSignatureWidget() const override;
   CPDF_Action GetAAction(CPDF_AAction::AActionType eAAT) override;
   bool IsAppearanceValid() override;
 
+  // CPDFSDK_Annot:
   int GetLayoutOrder() const override;
 
   FormFieldType GetFieldType() const;
@@ -93,9 +83,16 @@
   void SetTopVisibleIndex(int index);
 
 #ifdef PDF_ENABLE_XFA
+  CXFA_FFWidget* GetMixXFAWidget() const;
+  bool HasXFAAAction(PDFSDK_XFAAActionType eXFAAAT) const;
+  bool OnXFAAAction(PDFSDK_XFAAActionType eXFAAAT,
+                    CPDFSDK_FieldAction* data,
+                    CPDFSDK_PageView* pPageView);
+  void Synchronize(bool bSynchronizeElse);
   // TODO(thestig): Figure out if the parameter should be used or removed.
   void ResetXFAAppearance(bool bValueChanged);
 #endif  // PDF_ENABLE_XFA
+
   void ResetAppearance(Optional<WideString> sValue, bool bValueChanged);
   void ResetFieldAppearance();
   void UpdateField();
@@ -135,6 +132,7 @@
 
  private:
 #ifdef PDF_ENABLE_XFA
+  CXFA_FFWidgetHandler* GetXFAWidgetHandler() const;
   CXFA_FFWidget* GetGroupMixXFAWidget() const;
   WideString GetName() const;
 #endif  // PDF_ENABLE_XFA