commit 27aa5277fece779ea4f30d603b8cf354b634f3f6
author Tom Sepez <tsepez@chromium.org> Fri Jun 04 20:22:40 2021 +0000
committer Pdfium LUCI CQ <pdfium-scoped@luci-project-accounts.iam.gserviceaccount.com> Fri Jun 04 20:22:40 2021 +0000
tree 36a3db34c68b79578e8010ad935aa582792b90ac
parent 8c88a1a7ba16ab3d3c0aa37fdd5add6e322a137e

Remove CFWL_ComboEdit::FlagFocus() and CFWL_ComboList::SetNotifyOwner().

FlagFocus() is only called in one place with a fixed argument of
`true`, so inline the equivalent logic.

SetNotifyOwner() is uncalled.

Change-Id: I9d954e1f1c40075e73b74b60dc29f3b5cb45b955
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/81334
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Tom Sepez <tsepez@chromium.org>

xfa/fwl/cfwl_comboedit.cpp

diff --git a/xfa/fwl/cfwl_comboedit.cpp b/xfa/fwl/cfwl_comboedit.cpp
index 75c8136..ca78b84 100644
--- a/xfa/fwl/cfwl_comboedit.cpp
+++ b/xfa/fwl/cfwl_comboedit.cpp
@@ -23,20 +23,10 @@
 }
 
 void CFWL_ComboEdit::SetSelected() {
-  FlagFocus(true);
+  m_Properties.m_dwStates |= FWL_WGTSTATE_Focused;
   SelectAll();
 }
 
-void CFWL_ComboEdit::FlagFocus(bool bSet) {
-  if (bSet) {
-    m_Properties.m_dwStates |= FWL_WGTSTATE_Focused;
-    return;
-  }
-
-  m_Properties.m_dwStates &= ~FWL_WGTSTATE_Focused;
-  HideCaret(nullptr);
-}
-
 void CFWL_ComboEdit::OnProcessMessage(CFWL_Message* pMessage) {
   bool backDefault = true;
   switch (pMessage->GetType()) {

xfa/fwl/cfwl_comboedit.h

diff --git a/xfa/fwl/cfwl_comboedit.h b/xfa/fwl/cfwl_comboedit.h
index 23251b2..839eaed 100644
--- a/xfa/fwl/cfwl_comboedit.h
+++ b/xfa/fwl/cfwl_comboedit.h
@@ -20,7 +20,6 @@
 
   void ClearSelected();
   void SetSelected();
-  void FlagFocus(bool bSet);
 
  private:
   CFWL_ComboEdit(CFWL_App* app,

xfa/fwl/cfwl_combolist.h

diff --git a/xfa/fwl/cfwl_combolist.h b/xfa/fwl/cfwl_combolist.h
index f74dcd3..4f06b83 100644
--- a/xfa/fwl/cfwl_combolist.h
+++ b/xfa/fwl/cfwl_combolist.h
@@ -20,7 +20,6 @@
 
   int32_t MatchItem(WideStringView wsMatch);
   void ChangeSelected(int32_t iSel);
-  void SetNotifyOwner(bool notify) { m_bNotifyOwner = notify; }
 
  private:
   CFWL_ComboList(CFWL_App* app,