[SkiaPaths] Fixed missing texts.
In 3bigpreview.pdf, a lot of texts were not displayed because
|SkisState::m_rsxform| never gets reset to empty after drawing text
objects with RSX(rotation+scale matrix).
In DrawText(), after drawing a text object with RSX, if the next text
object has no RSX, |hasRSX| will contain the updated value as false,
and m_rsxform.isEmpty() will return true due to |SkisState::m_rsxform|
not getting reset, which causes FlushText() to be skipped. To fix it,
need to reset |SkisState::m_rsxform| when start drawing a new text
object.
Bug:pdfium:1355
Change-Id: I7476587d014a58467822a4dd5b1935760dabc924
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/58471
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
diff --git a/core/fxge/skia/fx_skia_device.cpp b/core/fxge/skia/fx_skia_device.cpp
index b7e205a..d98802e 100644
--- a/core/fxge/skia/fx_skia_device.cpp
+++ b/core/fxge/skia/fx_skia_device.cpp
@@ -878,6 +878,7 @@
if (Accumulator::kText != m_type) {
m_positions.setCount(0);
m_glyphs.setCount(0);
+ m_rsxform.setCount(0);
if (pFont->GetFaceRec())
m_pTypeFace.reset(SkSafeRef(pFont->GetDeviceCache()));
else
