commit 33d6766f5d519b215cde74ca1146d56319df820f
author Hui Yingst <nigi@chromium.org> Thu Mar 05 19:06:06 2020 +0000
committer Chromium commit bot <commit-bot@chromium.org> Thu Mar 05 19:06:06 2020 +0000
tree 33ec9b22c9437c020b023fa0812366ba39b1287e
parent bdfec55676eb4e8e6a78c711dca8be6e8a7872f1

Add a caller for FXSYS_ToUpperASCII() to simplify code.

In CBC_OnedCodaBarWriter::EncodeImpl(), replace lowercase ASCII
character to uppercase conversion code with a call to
FXSYS_ToUpperASCII().

Change-Id: I60a1b0c4a09aadb6386e6f86aedac6e181fede6e
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/67190
Commit-Queue: Hui Yingst <nigi@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>

fxbarcode/oned/BC_OnedCodaBarWriter.cpp

diff --git a/fxbarcode/oned/BC_OnedCodaBarWriter.cpp b/fxbarcode/oned/BC_OnedCodaBarWriter.cpp
index c4334c6..eb330a9 100644
--- a/fxbarcode/oned/BC_OnedCodaBarWriter.cpp
+++ b/fxbarcode/oned/BC_OnedCodaBarWriter.cpp
@@ -22,6 +22,7 @@
 
 #include "fxbarcode/oned/BC_OnedCodaBarWriter.h"
 
+#include "core/fxcrt/fx_extension.h"
 #include "fxbarcode/BC_Writer.h"
 #include "fxbarcode/common/BC_CommonBitMatrix.h"
 #include "fxbarcode/oned/BC_OneDimWriter.h"
@@ -139,10 +140,7 @@
   char ch;
   int32_t position = 0;
   for (size_t index = 0; index < data.GetLength(); index++) {
-    ch = data[index];
-    if (((ch >= 'a') && (ch <= 'z'))) {
-      ch = ch - 32;
-    }
+    ch = FXSYS_ToUpperASCII(data[index]);
     switch (ch) {
       case 'T':
         ch = 'A';