commit 3b37f6b44087b3e1dfc67e84add00fd889d14759
author Lei Zhang <thestig@chromium.org> Mon Jul 29 23:31:26 2019 +0000
committer Chromium commit bot <commit-bot@chromium.org> Mon Jul 29 23:31:26 2019 +0000
tree 18c0c5732595098e9d08af4a86ab9fdb7a818225
parent 0cbfa4a0c189f0e413fc952d71650ecc67f15d93

Remove a parameter to CPDFSDK_InteractiveForm::ResetFieldAppearance().

All the callers pass in the same argument.

Change-Id: I5f8c50f724c4aeefc26598a01229b6eba1db27f5
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/58331
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>

fpdfsdk/cpdfsdk_interactiveform.cpp

diff --git a/fpdfsdk/cpdfsdk_interactiveform.cpp b/fpdfsdk/cpdfsdk_interactiveform.cpp
index 67fa3e3..6d65d57 100644
--- a/fpdfsdk/cpdfsdk_interactiveform.cpp
+++ b/fpdfsdk/cpdfsdk_interactiveform.cpp
@@ -348,14 +348,14 @@
   return {};
 }
 
-void CPDFSDK_InteractiveForm::ResetFieldAppearance(CPDF_FormField* pFormField,
-                                                   Optional<WideString> sValue,
-                                                   bool bValueChanged) {
+void CPDFSDK_InteractiveForm::ResetFieldAppearance(
+    CPDF_FormField* pFormField,
+    Optional<WideString> sValue) {
   for (int i = 0, sz = pFormField->CountControls(); i < sz; i++) {
     CPDF_FormControl* pFormCtrl = pFormField->GetControl(i);
     ASSERT(pFormCtrl);
     if (CPDFSDK_Widget* pWidget = GetWidget(pFormCtrl))
-      pWidget->ResetAppearance(sValue, bValueChanged);
+      pWidget->ResetAppearance(sValue, true);
   }
 }
 
@@ -577,7 +577,7 @@
     return;
 
   OnCalculate(pField);
-  ResetFieldAppearance(pField, OnFormat(pField), true);
+  ResetFieldAppearance(pField, OnFormat(pField));
   UpdateField(pField);
 }
 
@@ -595,7 +595,7 @@
     return;
 
   OnCalculate(pField);
-  ResetFieldAppearance(pField, pdfium::nullopt, true);
+  ResetFieldAppearance(pField, pdfium::nullopt);
   UpdateField(pField);
 }
 

fpdfsdk/cpdfsdk_interactiveform.h

diff --git a/fpdfsdk/cpdfsdk_interactiveform.h b/fpdfsdk/cpdfsdk_interactiveform.h
index 151c57d..4e6deb8 100644
--- a/fpdfsdk/cpdfsdk_interactiveform.h
+++ b/fpdfsdk/cpdfsdk_interactiveform.h
@@ -71,8 +71,7 @@
   Optional<WideString> OnFormat(CPDF_FormField* pFormField);
 
   void ResetFieldAppearance(CPDF_FormField* pFormField,
-                            Optional<WideString> sValue,
-                            bool bValueChanged);
+                            Optional<WideString> sValue);
   void UpdateField(CPDF_FormField* pFormField);
 
   bool DoAction_Hide(const CPDF_Action& action);

fpdfsdk/cpdfsdk_widget.cpp

diff --git a/fpdfsdk/cpdfsdk_widget.cpp b/fpdfsdk/cpdfsdk_widget.cpp
index 35db23f..2889410 100644
--- a/fpdfsdk/cpdfsdk_widget.cpp
+++ b/fpdfsdk/cpdfsdk_widget.cpp
@@ -641,7 +641,7 @@
 void CPDFSDK_Widget::ResetFieldAppearance() {
   CPDF_FormField* pFormField = GetFormField();
   ASSERT(pFormField);
-  m_pInteractiveForm->ResetFieldAppearance(pFormField, pdfium::nullopt, true);
+  m_pInteractiveForm->ResetFieldAppearance(pFormField, pdfium::nullopt);
 }
 
 void CPDFSDK_Widget::DrawAppearance(CFX_RenderDevice* pDevice,

fpdfsdk/formfiller/cffl_interactiveformfiller.cpp

diff --git a/fpdfsdk/formfiller/cffl_interactiveformfiller.cpp b/fpdfsdk/formfiller/cffl_interactiveformfiller.cpp
index 4524719..e2c3b88 100644
--- a/fpdfsdk/formfiller/cffl_interactiveformfiller.cpp
+++ b/fpdfsdk/formfiller/cffl_interactiveformfiller.cpp
@@ -738,7 +738,7 @@
     return;
 
   if (sValue.has_value()) {
-    pForm->ResetFieldAppearance(pWidget->GetFormField(), sValue, true);
+    pForm->ResetFieldAppearance(pWidget->GetFormField(), sValue);
     pForm->UpdateField(pWidget->GetFormField());
   }