commit 3d29bcfeed81dbc8b3a63a5e81cca619bc11abb5
author Lei Zhang <thestig@chromium.org> Wed Dec 05 23:55:27 2018 +0000
committer Chromium commit bot <commit-bot@chromium.org> Wed Dec 05 23:55:27 2018 +0000
tree 9392ed5b89b82ba1f1ab380ff4780141334926af
parent 10a8fea122adf59768db9031b19e618ec41333e0

Change an if-statement into an ASSERT().

pdf_codec_fax_fuzzer has nearly complete coverage of CCodec_FaxModule
except for this one condition. It is likely not reachable.

Change-Id: I2efce532f6d590ed1693d7480a0ac40eab2059c5
Reviewed-on: https://pdfium-review.googlesource.com/c/46613
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>

core/fxcodec/codec/ccodec_faxmodule.cpp

diff --git a/core/fxcodec/codec/ccodec_faxmodule.cpp b/core/fxcodec/codec/ccodec_faxmodule.cpp
index 6a07d56..b9ee884 100644
--- a/core/fxcodec/codec/ccodec_faxmodule.cpp
+++ b/core/fxcodec/codec/ccodec_faxmodule.cpp
@@ -565,8 +565,7 @@
                                   int height,
                                   int pitch,
                                   uint8_t* dest_buf) {
-  if (pitch == 0)
-    pitch = (width + 7) / 8;
+  ASSERT(pitch != 0);
 
   std::vector<uint8_t> ref_buf(pitch, 0xff);
   int bitpos = starting_bitpos;