Fix a ClangTidy - Readability finding in pdfium.
These fixes are automatically created by various analysis tools, but
their application in this CL has been manually triggered.
* the 'empty' method should be used to check for emptiness instead of
'size'
PiperOrigin-RevId: 285199021
Change-Id: I4d9032985cabe13960ac68ba2fe39a1b5a425cae
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/63670
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Andrew Weintraub <asweintraub@google.com>
Commit-Queue: Lei Zhang <thestig@chromium.org>
diff --git a/core/fdrm/fx_crypt.cpp b/core/fdrm/fx_crypt.cpp
index 7e0ce7f..3d388d7 100644
--- a/core/fdrm/fx_crypt.cpp
+++ b/core/fdrm/fx_crypt.cpp
@@ -147,7 +147,8 @@
int j = 0;
for (int i = 0; i < kRC4ContextPermutationLength; ++i) {
- j = (j + context->m[i] + (key.size() ? key[i % key.size()] : 0)) & 0xFF;
+ size_t size = key.size();
+ j = (j + context->m[i] + (size ? key[i % size] : 0)) & 0xFF;
std::swap(context->m[i], context->m[j]);
}
}
