commit 4626e207e285e331f5a9f3547852c879a71a660b
author Tom Sepez <tsepez@chromium.org> Thu Dec 20 20:21:14 2018 +0000
committer Chromium commit bot <commit-bot@chromium.org> Thu Dec 20 20:21:14 2018 +0000
tree dcce24b65a9fa546ba7a9324dffa1b8de1531dbc
parent 81e9b6897fd3df0341ba5b0e626eca071a6a3f10

Remove CFX_FloatRect::Reset().

There is only one use and it is better served by assignment.

Change-Id: Ia4ed533407b54fa1ad4b86f310098f21bfa002bd
Reviewed-on: https://pdfium-review.googlesource.com/c/47610
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Tom Sepez <tsepez@chromium.org>

core/fxcrt/fx_coordinates.cpp

diff --git a/core/fxcrt/fx_coordinates.cpp b/core/fxcrt/fx_coordinates.cpp
index 2c92b3a..eade580 100644
--- a/core/fxcrt/fx_coordinates.cpp
+++ b/core/fxcrt/fx_coordinates.cpp
@@ -105,13 +105,6 @@
     std::swap(top, bottom);
 }
 
-void CFX_FloatRect::Reset() {
-  left = 0.0f;
-  right = 0.0f;
-  bottom = 0.0f;
-  top = 0.0f;
-}
-
 void CFX_FloatRect::Intersect(const CFX_FloatRect& other_rect) {
   Normalize();
   CFX_FloatRect other = other_rect;
@@ -121,7 +114,7 @@
   right = std::min(right, other.right);
   top = std::min(top, other.top);
   if (left > right || bottom > top)
-    Reset();
+    *this = CFX_FloatRect();
 }
 
 void CFX_FloatRect::Union(const CFX_FloatRect& other_rect) {

core/fxcrt/fx_coordinates.h

diff --git a/core/fxcrt/fx_coordinates.h b/core/fxcrt/fx_coordinates.h
index 35dc893..d6e1a05 100644
--- a/core/fxcrt/fx_coordinates.h
+++ b/core/fxcrt/fx_coordinates.h
@@ -236,10 +236,7 @@
 
   void Normalize();
 
-  void Reset();
-
   bool IsEmpty() const { return left >= right || bottom >= top; }
-
   bool Contains(const CFX_PointF& point) const;
   bool Contains(const CFX_FloatRect& other_rect) const;