commit 466c9dadca6bed6518fae0687ae996a780d20a2e
author Lei Zhang <thestig@chromium.org> Wed Mar 27 23:16:51 2019 +0000
committer Chromium commit bot <commit-bot@chromium.org> Wed Mar 27 23:16:51 2019 +0000
tree 1e9dd3ef250131dda999df25e1b318c269eee69b
parent 0e19f66fcb3a7059af6a5cb50e5cd36457cb0f76

Avoid an unnecessary loop in CPDF_FormField::IsItemSelected().

There is no need to go through all the elements in an array when the
caller knows it only wants the one at a particular position.

Change-Id: I64dc1b8de9fbbdb9b8fb79a3c4c019a9a180dec6
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/52550
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>

core/fpdfdoc/cpdf_formfield.cpp

diff --git a/core/fpdfdoc/cpdf_formfield.cpp b/core/fpdfdoc/cpdf_formfield.cpp
index d5ac71b..283c9b3 100644
--- a/core/fpdfdoc/cpdf_formfield.cpp
+++ b/core/fpdfdoc/cpdf_formfield.cpp
@@ -557,18 +557,12 @@
   if (!pArray)
     return false;
 
-  int iPos = -1;
-  for (int j = 0; j < CountSelectedOptions(); j++) {
-    if (GetSelectedOptionIndex(j) == index) {
-      iPos = j;
-      break;
+  for (int i = 0; i < CountSelectedOptions(); ++i) {
+    if (GetSelectedOptionIndex(i) == index) {
+      const CPDF_Object* pDirectObj = pArray->GetDirectObjectAt(i);
+      return pDirectObj && pDirectObj->GetUnicodeText() == opt_value;
     }
   }
-  for (int i = 0; i < static_cast<int>(pArray->size()); i++) {
-    const CPDF_Object* pDirectObj = pArray->GetDirectObjectAt(i);
-    if (pDirectObj && pDirectObj->GetUnicodeText() == opt_value && i == iPos)
-      return true;
-  }
   return false;
 }