commit 47562b3a626ce0a2d982f462b5965ce3c0e969fb
author Lei Zhang <thestig@chromium.org> Mon Apr 20 18:44:11 2020 +0000
committer Chromium commit bot <commit-bot@chromium.org> Mon Apr 20 18:44:11 2020 +0000
tree 20a2e41df5097ac180c8481214c3b28a6ae37130
parent 416bf2e2bf823159c738ae1fb15adddd492ddc38

Fix test expectations for BarcodeTest.Code128CLetters.

The "code 128 C" 1D barcode is named as such because it can accept most
ASCII characters. As such, its test should make sure
CBC_Code128::Encode() succeeds when the input is an ASCII string.

Bug: pdfium:1172
Change-Id: If593972199c936d91e27f0b1fe74bb75a0b197d2
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/68950
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>

fxbarcode/cfx_barcode_unittest.cpp

diff --git a/fxbarcode/cfx_barcode_unittest.cpp b/fxbarcode/cfx_barcode_unittest.cpp
index 7569bf2..3d4206a 100644
--- a/fxbarcode/cfx_barcode_unittest.cpp
+++ b/fxbarcode/cfx_barcode_unittest.cpp
@@ -138,9 +138,17 @@
   EXPECT_EQ("fba730a807ba6363f9bd2bc7f8c56d1f", BitmapChecksum());
 }
 
-TEST_F(BarcodeTest, DISABLED_Code128CLetters) {
+// https://crbug.com/pdfium/738
+#if defined(_SKIA_SUPPORT_) || defined(_SKIA_SUPPORT_PATHS_)
+#define MAYBE_Code128CLetters DISABLED_Code128CLetters
+#else
+#define MAYBE_Code128CLetters Code128CLetters
+#endif
+TEST_F(BarcodeTest, MAYBE_Code128CLetters) {
   Create(BC_CODE128_C);
-  EXPECT_FALSE(barcode()->Encode(L"clams"));
+  EXPECT_TRUE(barcode()->Encode(L"clams"));
+  RenderDevice();
+  EXPECT_EQ("6284ec8503d5a948c9518108da33cdd3", BitmapChecksum());
 }
 
 // https://crbug.com/pdfium/738