commit 47d4b58c611f0fa364307527c7ab6a26198d6fea
author Lei Zhang <thestig@chromium.org> Mon Sep 26 23:57:43 2022 +0000
committer Pdfium LUCI CQ <pdfium-scoped@luci-project-accounts.iam.gserviceaccount.com> Mon Sep 26 23:57:43 2022 +0000
tree 2f9c66310eeaba20ab9130bc955c443569885324
parent 841343eaa46e10cbfc405ef5ed6ebfa63801c84a

Rename some parameters in CPDF_RenderStatus.

For CPDF_RenderStatus::DrawShadingPattern(), the pattern parameter name
has a mismatch between the declaration and the definition. Fix this
mismatch, and also make DrawTilingPattern() use the same name for its
pattern parameter.

Change-Id: I1266eed474ce8fed19a19171cf404ca2a055bb73
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/98550
Reviewed-by: Nigi <nigi@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>

core/fpdfapi/render/cpdf_renderstatus.cpp

diff --git a/core/fpdfapi/render/cpdf_renderstatus.cpp b/core/fpdfapi/render/cpdf_renderstatus.cpp
index 9772b44..205b8aa 100644
--- a/core/fpdfapi/render/cpdf_renderstatus.cpp
+++ b/core/fpdfapi/render/cpdf_renderstatus.cpp
@@ -1189,11 +1189,11 @@
       m_Options);
 }
 
-void CPDF_RenderStatus::DrawTilingPattern(CPDF_TilingPattern* pPattern,
+void CPDF_RenderStatus::DrawTilingPattern(CPDF_TilingPattern* pattern,
                                           CPDF_PageObject* pPageObj,
                                           const CFX_Matrix& mtObj2Device,
                                           bool stroke) {
-  const std::unique_ptr<CPDF_Form> pPatternForm = pPattern->Load(pPageObj);
+  const std::unique_ptr<CPDF_Form> pPatternForm = pattern->Load(pPageObj);
   if (!pPatternForm)
     return;
 
@@ -1209,7 +1209,7 @@
     return;
 
   RetainPtr<CFX_DIBitmap> pScreen =
-      CPDF_RenderTiling::Draw(this, pPageObj, pPattern, pPatternForm.get(),
+      CPDF_RenderTiling::Draw(this, pPageObj, pattern, pPatternForm.get(),
                               mtObj2Device, clip_box, stroke);
   if (!pScreen)
     return;

core/fpdfapi/render/cpdf_renderstatus.h

diff --git a/core/fpdfapi/render/cpdf_renderstatus.h b/core/fpdfapi/render/cpdf_renderstatus.h
index a1e5079..6d0a180 100644
--- a/core/fpdfapi/render/cpdf_renderstatus.h
+++ b/core/fpdfapi/render/cpdf_renderstatus.h
@@ -103,11 +103,11 @@
   FX_ARGB GetFillArgb(CPDF_PageObject* pObj) const;
   FX_ARGB GetFillArgbForType3(CPDF_PageObject* pObj) const;
 
-  void DrawTilingPattern(CPDF_TilingPattern* pPattern,
+  void DrawTilingPattern(CPDF_TilingPattern* pattern,
                          CPDF_PageObject* pPageObj,
                          const CFX_Matrix& mtObj2Device,
                          bool stroke);
-  void DrawShadingPattern(CPDF_ShadingPattern* pPattern,
+  void DrawShadingPattern(CPDF_ShadingPattern* pattern,
                           const CPDF_PageObject* pPageObj,
                           const CFX_Matrix& mtObj2Device,
                           bool stroke);