commit 48c6288c84d2cec15591501f580d0e4ebbe9b013
author Lei Zhang <thestig@chromium.org> Tue Feb 11 23:43:13 2020 +0000
committer Chromium commit bot <commit-bot@chromium.org> Tue Feb 11 23:43:13 2020 +0000
tree d449e735a903759af1917dd80f49c98d3f5d7e4a
parent 4a0f1a01ac8a9214c791e99baaf2ddbe914629da

Add a test case for a FPDFText_GetLooseCharBox() bug.

Demonstrate FPDFText_GetLooseCharBox() currently does not return
consistent results for glyphs in font_matrix.pdf like
FPDFText_GetCharBox().

Bug: pdfium:1465
Change-Id: I441974e07c3ed5bb3c190550e15977a50004a679
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/65530
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>

fpdfsdk/fpdf_text_embeddertest.cpp

diff --git a/fpdfsdk/fpdf_text_embeddertest.cpp b/fpdfsdk/fpdf_text_embeddertest.cpp
index 06ff4cc..cd94620 100644
--- a/fpdfsdk/fpdf_text_embeddertest.cpp
+++ b/fpdfsdk/fpdf_text_embeddertest.cpp
@@ -1484,10 +1484,6 @@
   static_assert(kExpectedCount + 1 == kExpectedTextSize,
                 "Bad expected matrix size");
 
-  // For a size 12 letter 'A'.
-  constexpr double kExpectedCharWidth = 8.436;
-  constexpr double kExpectedCharHeight = 6.77;
-
   ASSERT_TRUE(OpenDocument("font_matrix.pdf"));
   FPDF_PAGE page = LoadPage(0);
   ASSERT_TRUE(page);
@@ -1507,26 +1503,6 @@
           check_unsigned_shorts(kExpectedText, buffer, kExpectedTextSize));
     }
 
-    {
-      // Check the character box size.
-      double left;
-      double right;
-      double bottom;
-      double top;
-      ASSERT_TRUE(FPDFText_GetCharBox(text_page.get(), 0, &left, &right,
-                                      &bottom, &top));
-      EXPECT_NEAR(kExpectedCharWidth, right - left, 0.001);
-      EXPECT_NEAR(kExpectedCharHeight, top - bottom, 0.001);
-      ASSERT_TRUE(FPDFText_GetCharBox(text_page.get(), 4, &left, &right,
-                                      &bottom, &top));
-      EXPECT_NEAR(kExpectedCharWidth, right - left, 0.001);
-      EXPECT_NEAR(kExpectedCharHeight, top - bottom, 0.001);
-      ASSERT_TRUE(FPDFText_GetCharBox(text_page.get(), 8, &left, &right,
-                                      &bottom, &top));
-      EXPECT_NEAR(kExpectedCharWidth, right - left, 0.001);
-      EXPECT_NEAR(kExpectedCharHeight, top - bottom, 0.001);
-    }
-
     // Check the character matrix.
     FS_MATRIX matrix;
     for (size_t i = 0; i < kExpectedCount; ++i) {
@@ -1548,3 +1524,53 @@
 
   UnloadPage(page);
 }
+
+TEST_F(FPDFTextEmbedderTest, CharBox) {
+  // For a size 12 letter 'A'.
+  constexpr double kExpectedCharWidth = 8.436;
+  constexpr double kExpectedCharHeight = 6.77;
+  constexpr float kExpectedLooseCharWidth = 8.664f;
+  constexpr float kExpectedLooseCharHeight = 12.0f;
+
+  ASSERT_TRUE(OpenDocument("font_matrix.pdf"));
+  FPDF_PAGE page = LoadPage(0);
+  ASSERT_TRUE(page);
+
+  {
+    ScopedFPDFTextPage text_page(FPDFText_LoadPage(page));
+    ASSERT_TRUE(text_page);
+
+    // Check the character box size.
+    double left;
+    double right;
+    double bottom;
+    double top;
+    ASSERT_TRUE(
+        FPDFText_GetCharBox(text_page.get(), 0, &left, &right, &bottom, &top));
+    EXPECT_NEAR(kExpectedCharWidth, right - left, 0.001);
+    EXPECT_NEAR(kExpectedCharHeight, top - bottom, 0.001);
+    ASSERT_TRUE(
+        FPDFText_GetCharBox(text_page.get(), 4, &left, &right, &bottom, &top));
+    EXPECT_NEAR(kExpectedCharWidth, right - left, 0.001);
+    EXPECT_NEAR(kExpectedCharHeight, top - bottom, 0.001);
+    ASSERT_TRUE(
+        FPDFText_GetCharBox(text_page.get(), 8, &left, &right, &bottom, &top));
+    EXPECT_NEAR(kExpectedCharWidth, right - left, 0.001);
+    EXPECT_NEAR(kExpectedCharHeight, top - bottom, 0.001);
+
+    // Check the loose character box size.
+    // TODO(crbug.com/pdfium/1465): There should be no division here.
+    FS_RECTF rect;
+    ASSERT_TRUE(FPDFText_GetLooseCharBox(text_page.get(), 0, &rect));
+    EXPECT_FLOAT_EQ(kExpectedLooseCharWidth / 12, rect.right - rect.left);
+    EXPECT_FLOAT_EQ(kExpectedLooseCharHeight / 12, rect.top - rect.bottom);
+    ASSERT_TRUE(FPDFText_GetLooseCharBox(text_page.get(), 4, &rect));
+    EXPECT_FLOAT_EQ(kExpectedLooseCharWidth / 12, rect.right - rect.left);
+    EXPECT_FLOAT_EQ(kExpectedLooseCharHeight / 12, rect.top - rect.bottom);
+    ASSERT_TRUE(FPDFText_GetLooseCharBox(text_page.get(), 8, &rect));
+    EXPECT_FLOAT_EQ(kExpectedLooseCharWidth, rect.right - rect.left);
+    EXPECT_FLOAT_EQ(kExpectedLooseCharHeight, rect.top - rect.bottom);
+  }
+
+  UnloadPage(page);
+}