commit 4de3a39f9d018d572f473b3239afb390b6baae8e
author Andrew Weintraub <asweintraub@google.com> Thu Jun 13 17:40:03 2019 +0000
committer Chromium commit bot <commit-bot@chromium.org> Thu Jun 13 17:40:03 2019 +0000
tree da6df81febfde2fa32b8b65a1c9bcc4088f98bc8
parent c7fd89e697e9bd16a13fdeea613831fe43536888

Automatic clang-tidy fixes.

These fixes are automatically created by various analysis
tools, but have been manually triggered to be applied.
See go/code-findings-fixes.

* passing result of std::move() as a const reference
  argument; no move will actually happen (2 times)

PiperOrigin-RevId: 253045380
Change-Id: I494fd37d36e11bb4975f78f76ee52a386fba3969
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/56150
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>

core/fpdfapi/page/cpdf_docpagedata.cpp

diff --git a/core/fpdfapi/page/cpdf_docpagedata.cpp b/core/fpdfapi/page/cpdf_docpagedata.cpp
index 9ad7df8..4d7a33b 100644
--- a/core/fpdfapi/page/cpdf_docpagedata.cpp
+++ b/core/fpdfapi/page/cpdf_docpagedata.cpp
@@ -131,7 +131,7 @@
   pBaseDict->SetNewFor<CPDF_Name>("BaseFont", basefont);
   pBaseDict->SetNewFor<CPDF_Number>("FirstChar", 32);
   pBaseDict->SetNewFor<CPDF_Number>("LastChar", 255);
-  pBaseDict->SetFor("Widths", std::move(pWidths));
+  pBaseDict->SetFor("Widths", pWidths);
 }
 
 RetainPtr<CPDF_Dictionary> CalculateFontDesc(CPDF_Document* pDoc,
@@ -146,7 +146,7 @@
   pFontDesc->SetNewFor<CPDF_Name>("Type", "FontDescriptor");
   pFontDesc->SetNewFor<CPDF_Name>("FontName", basefont);
   pFontDesc->SetNewFor<CPDF_Number>("Flags", flags);
-  pFontDesc->SetFor("FontBBox", std::move(bbox));
+  pFontDesc->SetFor("FontBBox", bbox);
   pFontDesc->SetNewFor<CPDF_Number>("ItalicAngle", italicangle);
   pFontDesc->SetNewFor<CPDF_Number>("Ascent", ascend);
   pFontDesc->SetNewFor<CPDF_Number>("Descent", descend);