commit 513184f7b5fc442ea1d7adb5a81b014107e60934
author Tom Sepez <tsepez@chromium.org> Thu Jan 16 21:49:27 2020 +0000
committer Chromium commit bot <commit-bot@chromium.org> Thu Jan 16 21:49:27 2020 +0000
tree e95312c0f5ce4b2d768e12fb13bd40d0fa30bacd
parent f133db638bd2da0eebdf434b4d157c2e5dacd63c

Add test for growing gap in CFDE_TextEditEngine::AdjustGap().

Shown uncovered by code coverage bots.

- Remove unused GetFontAscent() while at it.

Change-Id: I5535777dd89b002ae9c38d530fd2b09e0642460c
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/65210
Commit-Queue: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>

xfa/fde/cfde_texteditengine.cpp

diff --git a/xfa/fde/cfde_texteditengine.cpp b/xfa/fde/cfde_texteditengine.cpp
index 0df28b4..b13699e 100644
--- a/xfa/fde/cfde_texteditengine.cpp
+++ b/xfa/fde/cfde_texteditengine.cpp
@@ -694,10 +694,6 @@
   is_dirty_ = true;
 }
 
-float CFDE_TextEditEngine::GetFontAscent() const {
-  return (static_cast<float>(font_->GetAscent()) * font_size_) / 1000;
-}
-
 void CFDE_TextEditEngine::SetAlignment(uint32_t alignment) {
   if (alignment == character_alignment_)
     return;

xfa/fde/cfde_texteditengine.h

diff --git a/xfa/fde/cfde_texteditengine.h b/xfa/fde/cfde_texteditengine.h
index d95994d..d68aa41 100644
--- a/xfa/fde/cfde_texteditengine.h
+++ b/xfa/fde/cfde_texteditengine.h
@@ -113,7 +113,6 @@
   float GetFontSize() const { return font_size_; }
   void SetFontColor(FX_ARGB color) { font_color_ = color; }
   FX_ARGB GetFontColor() const { return font_color_; }
-  float GetFontAscent() const;
 
   void SetAlignment(uint32_t alignment);
   float GetLineSpace() const { return line_spacing_; }

xfa/fde/cfde_texteditengine_unittest.cpp

diff --git a/xfa/fde/cfde_texteditengine_unittest.cpp b/xfa/fde/cfde_texteditengine_unittest.cpp
index f1fc182..87e29aa 100644
--- a/xfa/fde/cfde_texteditengine_unittest.cpp
+++ b/xfa/fde/cfde_texteditengine_unittest.cpp
@@ -179,6 +179,21 @@
   EXPECT_STREQ(L"*HelloWorld", engine()->GetText().c_str());
 }
 
+TEST_F(CFDE_TextEditEngineTest, InsertGrowGap) {
+  engine()->Insert(0, L"||");
+  for (size_t i = 1; i < 1023; ++i) {
+    engine()->Insert(i, L"a");
+  }
+  WideString result = engine()->GetText();
+  ASSERT_EQ(result.GetLength(), 1024u);
+  EXPECT_EQ(result[0], L'|');
+  EXPECT_EQ(result[1], L'a');
+  EXPECT_EQ(result[2], L'a');
+  // ...
+  EXPECT_EQ(result[1022], L'a');
+  EXPECT_EQ(result[1023], L'|');
+}
+
 TEST_F(CFDE_TextEditEngineTest, Delete) {
   EXPECT_STREQ(L"", engine()->Delete(0, 50).c_str());
   EXPECT_STREQ(L"", engine()->GetText().c_str());