Correct the names of the FX_SAFE_* typedefs. R=jun_fang@foxitsoftware.com Review URL: https://codereview.chromium.org/417263008
diff --git a/core/include/fxcrt/fx_system.h b/core/include/fxcrt/fx_system.h index 3913803..6d659e2 100644 --- a/core/include/fxcrt/fx_system.h +++ b/core/include/fxcrt/fx_system.h
@@ -277,9 +277,9 @@ }; #include "../../../third_party/numerics/safe_math.h" -typedef base::CheckedNumeric<FX_DWORD> FX_SAFE_DWORD; -typedef base::CheckedNumeric<FX_INT32> FX_SAFE_INT; -typedef base::CheckedNumeric<size_t> FX_SAFE_SIZET; +typedef base::CheckedNumeric<FX_DWORD> FX_SAFE_DWORD; +typedef base::CheckedNumeric<FX_INT32> FX_SAFE_INT32; +typedef base::CheckedNumeric<size_t> FX_SAFE_SIZE_T; #if defined(__clang__) || _MSC_VER >= 1700 #define FX_FINAL final #elif defined(__GNUC__) && __cplusplus >= 201103 && \
diff --git a/core/src/fpdfapi/fpdf_render/fpdf_render_loadimage.cpp b/core/src/fpdfapi/fpdf_render/fpdf_render_loadimage.cpp index 5279ab9..7e80f75 100644 --- a/core/src/fpdfapi/fpdf_render/fpdf_render_loadimage.cpp +++ b/core/src/fpdfapi/fpdf_render/fpdf_render_loadimage.cpp
@@ -1204,7 +1204,7 @@ return; } - FX_SAFE_INT max_src_x = clip_left; + FX_SAFE_INT32 max_src_x = clip_left; max_src_x += clip_width - 1; max_src_x *= src_width; max_src_x /= dest_width;
diff --git a/core/src/fxcrt/extension.h b/core/src/fxcrt/extension.h index d04d1da..6221d14 100644 --- a/core/src/fxcrt/extension.h +++ b/core/src/fxcrt/extension.h
@@ -230,7 +230,7 @@ offset = safeOffset.ValueOrDie(); - FX_SAFE_SIZET newPos = size; + FX_SAFE_SIZE_T newPos = size; newPos += offset; if (!newPos.IsValid() || newPos.ValueOrDefault(0) == 0 || newPos.ValueOrDie() >= m_nCurSize) { return FALSE; @@ -282,7 +282,7 @@ offset += (FX_FILESIZE)m_nOffset; } if (m_dwFlags & FX_MEMSTREAM_Consecutive) { - FX_SAFE_SIZET newPos = size; + FX_SAFE_SIZE_T newPos = size; newPos += offset; if (!newPos.IsValid()) return FALSE; @@ -308,7 +308,7 @@ return TRUE; } - FX_SAFE_SIZET newPos = size; + FX_SAFE_SIZE_T newPos = size; newPos += offset; if (!newPos.IsValid()) { return FALSE;