commit 542b7933970d10e557b97c80060da6b0e5f1e74b
author Lei Zhang <thestig@chromium.org> Mon Sep 16 19:55:35 2019 +0000
committer Chromium commit bot <commit-bot@chromium.org> Mon Sep 16 19:55:35 2019 +0000
tree 572df8c9578343ba1abdff88641c4a35fb125230
parent 03e5e6883831019a7386322cf6f3984ba052afd6

Disable embedder tests that fail when Skia is enabled.

The tests do not pass yet when Skia is enabled. So disable them for now
to allow us to be able to run embedder tests.

Bug: pdfium:11
Change-Id: Iff577cbb40c8785200fa005d96afd8712d1feee6
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/60691
Reviewed-by: dsinclair <dsinclair@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>

core/fxcodec/jbig2/jbig2_embeddertest.cpp

diff --git a/core/fxcodec/jbig2/jbig2_embeddertest.cpp b/core/fxcodec/jbig2/jbig2_embeddertest.cpp
index 8acd884..e2523fc 100644
--- a/core/fxcodec/jbig2/jbig2_embeddertest.cpp
+++ b/core/fxcodec/jbig2/jbig2_embeddertest.cpp
@@ -10,7 +10,13 @@
 
 class JBig2EmbedderTest : public EmbedderTest {};
 
-TEST_F(JBig2EmbedderTest, Bug_631912) {
+#if defined(_SKIA_SUPPORT_)
+// TODO(crbug.com/pdfium/11): Fix this test and enable.
+#define MAYBE_Bug_631912 DISABLED_Bug_631912
+#else
+#define MAYBE_Bug_631912 Bug_631912
+#endif
+TEST_F(JBig2EmbedderTest, MAYBE_Bug_631912) {
   // Test jbig2 image in PDF file can be loaded successfully.
   // Should not crash.
   EXPECT_TRUE(OpenDocument("bug_631912.pdf"));

core/fxge/skia/fx_skia_device_embeddertest.cpp

diff --git a/core/fxge/skia/fx_skia_device_embeddertest.cpp b/core/fxge/skia/fx_skia_device_embeddertest.cpp
index d506555..6631e4d 100644
--- a/core/fxge/skia/fx_skia_device_embeddertest.cpp
+++ b/core/fxge/skia/fx_skia_device_embeddertest.cpp
@@ -159,7 +159,8 @@
 }
 
 #ifdef _SKIA_SUPPORT_
-TEST(fxge, SkiaStateText) {
+// TODO(crbug.com/pdfium/11): Fix this test and enable.
+TEST(fxge, DISABLED_SkiaStateText) {
   Harness(&CommonTest,
           {State::Change::kNo, State::Save::kYes, State::Clip::kDifferentMatrix,
            State::Graphic::kText, 0xFF445566});