commit 5430882578c1e752cce29827dfb669a7590405b5
author Lei Zhang <thestig@chromium.org> Fri May 03 18:48:16 2019 +0000
committer Chromium commit bot <commit-bot@chromium.org> Fri May 03 18:48:16 2019 +0000
tree 3bf4f95629e6d5d1d81ececef51b237a10a60267
parent b0bcefa28eb91e4c7168e1ab80e7b4c8aaab51ff

Change the goal for FPDFViewEmbedderTest.BUG_1281

Use it to show FPDF_REVERSE_BYTE_ORDER does not work with
FPDF_RenderPage(). The comment for FPDF_REVERSE_BYTE_ORDER in the header
already says it only works for bitmaps.

BUG=pdfium:1281

Change-Id: I1dcd64055335b9939f13d5b4e511cc87e4389b46
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/53615
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>

fpdfsdk/fpdf_view_embeddertest.cpp

diff --git a/fpdfsdk/fpdf_view_embeddertest.cpp b/fpdfsdk/fpdf_view_embeddertest.cpp
index efa3c7b..d8eef2c 100644
--- a/fpdfsdk/fpdf_view_embeddertest.cpp
+++ b/fpdfsdk/fpdf_view_embeddertest.cpp
@@ -908,17 +908,17 @@
 }
 
 #if defined(OS_WIN)
-// Tests using FPDF_REVERSE_BYTE_ORDER with FPDF_RenderPage(). The two rendered
-// EMFs should be different.
-TEST_F(FPDFViewEmbedderTest, BUG_1281) {
+TEST_F(FPDFViewEmbedderTest, FPDF_RenderPage) {
   ASSERT_TRUE(OpenDocument("rectangles.pdf"));
   FPDF_PAGE page = LoadPage(0);
   ASSERT_TRUE(page);
 
   std::vector<uint8_t> emf_normal = RenderPageWithFlagsToEmf(page, 0);
+  EXPECT_EQ(3772u, emf_normal.size());
+
+  // FPDF_REVERSE_BYTE_ORDER is ignored since EMFs are always BGR.
   std::vector<uint8_t> emf_reverse_byte_order =
       RenderPageWithFlagsToEmf(page, FPDF_REVERSE_BYTE_ORDER);
-  // TODO(https://crbug.com/pdfium/1281): These should not be equal.
   EXPECT_EQ(emf_normal, emf_reverse_byte_order);
 
   UnloadPage(page);