commit 55b4d9edbcc68997325ae2a7a39715cdd59f02ec
author Hui Yingst <nigi@chromium.org> Thu Sep 10 22:31:57 2020 +0000
committer Chromium commit bot <commit-bot@chromium.org> Thu Sep 10 22:31:57 2020 +0000
tree 0688ed9275af4ac46afdbda47f977168d1ae165c
parent d2d4f96ac14dc541346f263e25cbe401f39a3581

Enable FPDFFlattenEmbedderTest.BUG_896366 for Skia.

When Skia/SkiaPaths is enabled, FPDFFlattenEmbedderTest.BUG_896366 fails
due to Skia's own way of hairline handling along the edges of a
rectangle. Since the discrepancy between AGG's and Skia's rendering
results is not obvious to human eyes and it goes away as the scale of
rendering goes up, we consider Skia's rendering result acceptable.

This CL adds the expected checksum for using Skia/SkiaPaths so that the
test can pass.

Bug: pdfium:1500
Change-Id: Idf6d7cffcf3e5709ffadca9053cac4afd3924d64
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/73491
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Hui Yingst <nigi@chromium.org>

fpdfsdk/fpdf_flatten_embeddertest.cpp

diff --git a/fpdfsdk/fpdf_flatten_embeddertest.cpp b/fpdfsdk/fpdf_flatten_embeddertest.cpp
index a0b7ff9..5d6a434 100644
--- a/fpdfsdk/fpdf_flatten_embeddertest.cpp
+++ b/fpdfsdk/fpdf_flatten_embeddertest.cpp
@@ -119,25 +119,23 @@
   VerifySavedDocument(200, 200, kChecksum);
 }
 
-// TODO(crbug.com/pdfium/11): Fix this test and enable.
+TEST_F(FPDFFlattenEmbedderTest, BUG_896366) {
 #if defined(_SKIA_SUPPORT_) || defined(_SKIA_SUPPORT_PATHS_)
-#define MAYBE_BUG_896366 DISABLED_BUG_896366
+  constexpr char kChecksum[] = "c3cccfadc4c5249e6aa0675e511fa4c3";
 #else
-#define MAYBE_BUG_896366 BUG_896366
+  constexpr char kChecksum[] = "f71ab085c52c8445ae785eca3ec858b1";
 #endif
-TEST_F(FPDFFlattenEmbedderTest, MAYBE_BUG_896366) {
-  constexpr char md5_hash[] = "f71ab085c52c8445ae785eca3ec858b1";
   ASSERT_TRUE(OpenDocument("bug_896366.pdf"));
   FPDF_PAGE page = LoadPage(0);
   ASSERT_TRUE(page);
 
   ScopedFPDFBitmap bitmap = RenderLoadedPageWithFlags(page, FPDF_ANNOT);
-  CompareBitmap(bitmap.get(), 612, 792, md5_hash);
+  CompareBitmap(bitmap.get(), 612, 792, kChecksum);
 
   EXPECT_EQ(FLATTEN_SUCCESS, FPDFPage_Flatten(page, FLAT_PRINT));
   EXPECT_TRUE(FPDF_SaveAsCopy(document(), this, 0));
 
   UnloadPage(page);
 
-  VerifySavedDocument(612, 792, md5_hash);
+  VerifySavedDocument(612, 792, kChecksum);
 }