commit 578b06eded4570e31a1aa4653881a68ac9ed4531
author Lei Zhang <thestig@chromium.org> Sat Aug 07 15:20:01 2021 +0000
committer Pdfium LUCI CQ <pdfium-scoped@luci-project-accounts.iam.gserviceaccount.com> Sat Aug 07 15:20:01 2021 +0000
tree cf00f9aae2add134adc363958c5e0daa87d18714
parent 13374104b0457715cecb64df701c68ed906970fc

Rename CFX_PSRenderer::WriteToStream() to WriteStream().

It writes out the stream parameter, not write to it. Rename the method
name so it fits better with the other WriteFoo() method. Also change its
parameter to a reference and remove a useless std::ostringstream::str()
call.

Change-Id: I6ab3ab280ef0a3d887581dbb7a4ee10302e54f36
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/83960
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>

core/fxge/win32/cfx_psrenderer.cpp

diff --git a/core/fxge/win32/cfx_psrenderer.cpp b/core/fxge/win32/cfx_psrenderer.cpp
index bab804a..1557453 100644
--- a/core/fxge/win32/cfx_psrenderer.cpp
+++ b/core/fxge/win32/cfx_psrenderer.cpp
@@ -147,7 +147,7 @@
       }
     }
   }
-  WriteToStream(&buf);
+  WriteStream(buf);
 }
 
 void CFX_PSRenderer::SetClip_PathFill(
@@ -181,7 +181,7 @@
   buf << "mx Cm [" << pObject2Device->a << " " << pObject2Device->b << " "
       << pObject2Device->c << " " << pObject2Device->d << " "
       << pObject2Device->e << " " << pObject2Device->f << "]cm ";
-  WriteToStream(&buf);
+  WriteStream(buf);
 
   OutputPath(pPath, nullptr);
   CFX_FloatRect rect = pPath->GetBoundingBoxForStrokePath(
@@ -214,7 +214,7 @@
       buf << "mx Cm [" << pObject2Device->a << " " << pObject2Device->b << " "
           << pObject2Device->c << " " << pObject2Device->d << " "
           << pObject2Device->e << " " << pObject2Device->f << "]cm ";
-      WriteToStream(&buf);
+      WriteStream(buf);
     }
   }
 
@@ -274,7 +274,7 @@
   }
   m_CurGraphState = *pGraphState;
   m_bGraphStateSet = true;
-  WriteToStream(&buf);
+  WriteStream(buf);
 }
 
 bool CFX_PSRenderer::SetDIBits(const RetainPtr<CFX_DIBBase>& pSource,
@@ -358,7 +358,7 @@
     else
       buf << "false 1 colorimage\n";
 
-    WriteToStream(&buf);
+    WriteStream(buf);
     WritePSBinary({output_buf.get(), output_size});
   } else {
     CFX_DIBExtractor source_extractor(pSource);
@@ -427,7 +427,7 @@
 
     buf << "false " << bpp;
     buf << " colorimage\n";
-    WriteToStream(&buf);
+    WriteStream(buf);
 
     WritePSBinary({output_buf, output_size});
     FX_Free(output_buf);
@@ -445,7 +445,7 @@
       << FXARGB_B(color) / 255.0 << " rg\n";
   m_bColorSet = true;
   m_LastColor = color;
-  WriteToStream(&buf);
+  WriteStream(buf);
 }
 
 void CFX_PSRenderer::FindPSFontGlyph(CFX_GlyphCache* pGlyphCache,
@@ -491,8 +491,7 @@
            "currentdict end\n";
     buf << "/X" << static_cast<uint32_t>(m_PSFontList.size() - 1)
         << " exch definefont pop\n";
-    WriteToStream(&buf);
-    buf.str("");
+    WriteStream(buf);
   }
 
   *ps_fontnum = m_PSFontList.size() - 1;
@@ -552,7 +551,7 @@
   buf << "f}bind def end\n";
   buf << "/X" << *ps_fontnum << " Ff/Encoding get " << glyphindex << "/"
       << glyphindex << " put\n";
-  WriteToStream(&buf);
+  WriteStream(buf);
 }
 
 bool CFX_PSRenderer::DrawText(int nChars,
@@ -602,7 +601,7 @@
     buf << hex.AsStringView() << "Tj\n";
   }
   buf << "Q\n";
-  WriteToStream(&buf);
+  WriteStream(buf);
   return true;
 }
 
@@ -670,7 +669,7 @@
   }
 }
 
-void CFX_PSRenderer::WriteToStream(std::ostringstream* stringStream) {
-  if (stringStream->tellp() > 0)
-    m_pStream->WriteBlock(stringStream->str().c_str(), stringStream->tellp());
+void CFX_PSRenderer::WriteStream(std::ostringstream& stream) {
+  if (stream.tellp() > 0)
+    m_pStream->WriteBlock(stream.str().c_str(), stream.tellp());
 }

core/fxge/win32/cfx_psrenderer.h

diff --git a/core/fxge/win32/cfx_psrenderer.h b/core/fxge/win32/cfx_psrenderer.h
index e61fb31..2703714 100644
--- a/core/fxge/win32/cfx_psrenderer.h
+++ b/core/fxge/win32/cfx_psrenderer.h
@@ -121,7 +121,7 @@
                       uint32_t* output_size,
                       const char** filter) const;
   void WritePSBinary(pdfium::span<const uint8_t> data);
-  void WriteToStream(std::ostringstream* stringStream);
+  void WriteStream(std::ostringstream& stream);
 
   bool m_bInited = false;
   bool m_bGraphStateSet = false;