Turn DCHECKs into CHECKs in cpwl_edit_impl.cpp

These are all fast checks and crash reports are good. Using DCHECK
recently hid a bug.

Bug: 445725426
Change-Id: Ibdf87ac6debb1d30367204421daa8b7df6282497
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/135852
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: dan sinclair <dsinclair@chromium.org>
Commit-Queue: April Kallmeyer <ask@chromium.org>

fpdfsdk/pwl/cpwl_edit_impl.cpp

diff --git a/fpdfsdk/pwl/cpwl_edit_impl.cpp b/fpdfsdk/pwl/cpwl_edit_impl.cpp
index 76a4d79..f5a73d0 100644
--- a/fpdfsdk/pwl/cpwl_edit_impl.cpp
+++ b/fpdfsdk/pwl/cpwl_edit_impl.cpp
@@ -42,7 +42,7 @@
 
   CFX_PointF pos = mtUser2Device.Transform(pt);
   CPDF_RenderOptions ro;
-  DCHECK(ro.GetOptions().bClearType);
+  CHECK(ro.GetOptions().bClearType);
   ro.SetColorMode(CPDF_RenderOptions::kNormal);
   CPDF_TextRenderer::DrawTextString(pDevice, pos.x, pos.y, font, fFontSize,
                                     mtUser2Device, str, crTextFill, ro);
@@ -61,7 +61,7 @@
 }
 
 bool CPWL_EditImpl::Iterator::GetWord(CPVT_Word& word) const {
-  DCHECK(edit_);
+  CHECK(edit_);
 
   if (vt_iterator_->GetWord(word)) {
     word.ptWord = edit_->VTToEdit(word.ptWord);
@@ -71,7 +71,7 @@
 }
 
 bool CPWL_EditImpl::Iterator::GetLine(CPVT_Line& line) const {
-  DCHECK(edit_);
+  CHECK(edit_);
 
   if (vt_iterator_->GetLine(line)) {
     line.ptLine = edit_->VTToEdit(line.ptLine);
@@ -187,7 +187,7 @@
 }
 
 void CPWL_EditImpl::UndoStack::Undo() {
-  DCHECK(!working_);
+  CHECK(!working_);
   working_ = true;
   bool first_undo = true;
   while (CanUndo()) {
@@ -206,7 +206,7 @@
       }
     }
   }
-  DCHECK(working_);
+  CHECK(working_);
   working_ = false;
 }
 
@@ -215,7 +215,7 @@
 }
 
 void CPWL_EditImpl::UndoStack::Redo() {
-  DCHECK(!working_);
+  CHECK(!working_);
   working_ = true;
 
   bool first_undo = true;
@@ -234,7 +234,7 @@
       }
     }
   }
-  DCHECK(working_);
+  CHECK(working_);
   working_ = false;
 }
 
@@ -244,8 +244,8 @@
 }
 
 void CPWL_EditImpl::UndoStack::AddItem(std::unique_ptr<UndoItemIface> pItem) {
-  DCHECK(!working_);
-  DCHECK(pItem);
+  CHECK(!working_);
+  CHECK(pItem);
   if (CanRedo()) {
     RemoveTails();
   }
@@ -259,7 +259,7 @@
 }
 
 void CPWL_EditImpl::UndoStack::RemoveHeads() {
-  DCHECK(!undo_item_stack_.empty());
+  CHECK(!undo_item_stack_.empty());
   if (!undo_item_stack_.front()->IsSentinel()) {
     undo_item_stack_.pop_front();
     return;
@@ -317,7 +317,7 @@
       wp_new_(wpNewPlace),
       word_(word),
       charset_(charset) {
-  DCHECK(edit_);
+  CHECK(edit_);
 }
 
 CPWL_EditImpl::UndoInsertWord::~UndoInsertWord() = default;
@@ -358,7 +358,7 @@
     const CPVT_WordPlace& wpOldPlace,
     const CPVT_WordPlace& wpNewPlace)
     : edit_(pEdit), wp_old_(wpOldPlace), wp_new_(wpNewPlace) {
-  DCHECK(edit_);
+  CHECK(edit_);
 }
 
 CPWL_EditImpl::UndoInsertReturn::~UndoInsertReturn() = default;
@@ -422,7 +422,7 @@
       wp_new_(wpNewPlace),
       word_(word),
       charset_(charset) {
-  DCHECK(edit_);
+  CHECK(edit_);
 }
 
 CPWL_EditImpl::UndoBackspace::~UndoBackspace() = default;
@@ -479,7 +479,7 @@
       word_(word),
       charset_(charset),
       sec_end_(bSecEnd) {
-  DCHECK(edit_);
+  CHECK(edit_);
 }
 
 CPWL_EditImpl::UndoDelete::~UndoDelete() = default;
@@ -522,7 +522,7 @@
                                     const CPVT_WordRange& wrSel,
                                     const WideString& swText)
     : edit_(pEdit), wr_sel_(wrSel), sw_text_(swText) {
-  DCHECK(edit_);
+  CHECK(edit_);
 }
 
 CPWL_EditImpl::UndoClear::~UndoClear() = default;
@@ -573,7 +573,7 @@
       wp_new_(wpNewPlace),
       sw_text_(swText),
       charset_(charset) {
-  DCHECK(edit_);
+  CHECK(edit_);
 }
 
 CPWL_EditImpl::UndoInsertText::~UndoInsertText() = default;